From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F58A43D14; Thu, 21 Mar 2024 11:16:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8946942DC3; Thu, 21 Mar 2024 11:16:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B5D3640261 for ; Thu, 21 Mar 2024 11:16:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711016163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJLCJybxyJuaQ857cDOc086msB3juGWRz/dwOVC/Uj0=; b=JHW3oZmPArkBjtoq3/an1rVNHbv+yutEa/JTTWwjGAX1sUfgezn3Qq2HJj0xZ8ab8knQUV hKs5Ip1mtwicvJwcVMWJlcrlpDZBRp9kdl+GJHe2WBFeuMOZWSsAwtcIMDr2BCMLeb6/LD q/vS8Inio1OY2doJBpB0oayHUhiRUmU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-ZbDb8C-NM7WTDEBawxGiaA-1; Thu, 21 Mar 2024 06:15:59 -0400 X-MC-Unique: ZbDb8C-NM7WTDEBawxGiaA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d4a8dc0e79so9165501fa.1 for ; Thu, 21 Mar 2024 03:15:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711016158; x=1711620958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJLCJybxyJuaQ857cDOc086msB3juGWRz/dwOVC/Uj0=; b=aga9d7CLiFSdCO+DSUitr2/en7arEIgwInp5NxvYdOtv2fjHhuSLH4roZz0qPPvEsI +jg7wbed4G+DCR2Mey95flbh8irkTNAjb3JsGPs9GD5Q9J03Dvjn1TxCFteeNrduKWU+ ThMxnTjhiXntk1xJ1py5gSQcmxOhIDNCMleKNn9148xQxmGVH3BPzzbv0SqpsHfYUPEY /XpL4tdUE4E9NmW/euoXQ49u2auqeAk9CxsGbRgB7pUkre6EfGPWuK91qNapscXgFNC1 n00Uzr2Kms0s/JT6L8lMFGsrK7zqdBplGGJI74HilViVDWOuWyM35WIW/sjGg+RizoZa qlSw== X-Gm-Message-State: AOJu0YwPF42pszY0ymxvv9/6fpmJJwuEYmKmZZAvaR8RRD3m9qEEe09V uPONlwxJI6XW8zg9I3jh+92AQOR/ZBsUmqwJutqdR9Id4gkhNB8XUJYnK7miaZWlqmO/A4YuLAV 8/IOUYVF7HSBhAomZ8szNg0g7eqcAv94v3gn24Fu1vRMKEpp1eb06f8vWFAcn4r1PjwMw+HiBxu LdkUrB6yVlSJIlzcs= X-Received: by 2002:a2e:b80e:0:b0:2d3:f352:3406 with SMTP id u14-20020a2eb80e000000b002d3f3523406mr5267073ljo.46.1711016158536; Thu, 21 Mar 2024 03:15:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGI3ZpGG60gELUbwJ+QSgVlSHJ9FJdjJi0RyVnjx6m4DnNjFPdl32DXlQe9Ump9acFYIMcJYtnOnDOmXVstAI= X-Received: by 2002:a2e:b80e:0:b0:2d3:f352:3406 with SMTP id u14-20020a2eb80e000000b002d3f3523406mr5267062ljo.46.1711016158195; Thu, 21 Mar 2024 03:15:58 -0700 (PDT) MIME-Version: 1.0 References: <20240320130255.1526-1-thj@freebsd.org> <20240321095029.1216-1-thj@freebsd.org> In-Reply-To: <20240321095029.1216-1-thj@freebsd.org> From: David Marchand Date: Thu, 21 Mar 2024 11:15:46 +0100 Message-ID: Subject: Re: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD To: Tom Jones Cc: dev@dpdk.org, Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tom, On Thu, Mar 21, 2024 at 11:00=E2=80=AFAM Tom Jones wrote: > > Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver > as they are not supported. Rx queue interrupts were missed by this > change, don't attempt to enable them on FreeBSD. > > Without this change applications enabling interrupts encounter an > immediate abort on FreeBSD. Thanks for the patch, you will probably want this fix backported in LTS versions. If so, please add a Fixes: tag and Cc: stable@dpdk.org. I guess here, it is: Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD") Cc: Bruce Reading again the commitlog, I wonder if we should error out in vmxnet3_configure_msix() if rx (and/or lsc) interrupts are requested for FreeBSD. Did you consider this approach? --=20 David Marchand