From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD1AEA0543; Thu, 15 Dec 2022 10:59:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F182040684; Thu, 15 Dec 2022 10:59:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 66B3140223 for ; Thu, 15 Dec 2022 10:59:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671098361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0BUt8AC7scVRAzBazrh2h7VFDmySL9mQhrtUCQRoSdg=; b=EgrzG9511Q/S8DWqgnd5e7J40UjBcQvI7FvXtMlPvdsqRd6OO29ksxHQcD4BkiyrIctlqD h9HmFSODeQKj6e10jfHqp3ge6hU1ECDqciaEttevxe4ugrMng1jhtQ1x9DTER5NRrfpHUY +nvy+bwX9lwFLl1chUu1hyj7nnKiaRs= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-151-zWnXJ8iqNfaQ5yPEFgdNlA-1; Thu, 15 Dec 2022 04:59:20 -0500 X-MC-Unique: zWnXJ8iqNfaQ5yPEFgdNlA-1 Received: by mail-pl1-f200.google.com with SMTP id b17-20020a170903229100b00189da3b178bso4781223plh.7 for ; Thu, 15 Dec 2022 01:59:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0BUt8AC7scVRAzBazrh2h7VFDmySL9mQhrtUCQRoSdg=; b=TR0yUgE+wLq5xLEqEINGpIEk0XoIewzkfbm7GRmlzs0P6MJ0JxpiuOhYnxvJipr0+8 oRJF2jcWwh3ybNRLaUiOuPjTSS1VfuKBiVOL13xgtFZCMXPGlf4MCs2ukNxVtjlWar84 TwxNRjsXA1FoWE2UTsOSMNLylO2ACUcdKci5UhxL77bxa7sZ0iruEg33niZNXi4gy7xU LY6W4ryeClV3NoxVRIzcClbRJDs1BRirKLqQbnCHZsRdNR2v7lg8aSrx6cju0/PBU4mq wSGE7t1fhLJdVFFj4bYEPlGELoFSaOOGduiyr1ONWQ6gYzITfviwdUNubDJqeDHjtCV3 5ITA== X-Gm-Message-State: ANoB5pkyn3wphxEUdZgYikJy64pCmP0H5BWtHPms1XJ9Sxi+y8bdlWV9 ceFPFL19VeckOcx8H+2py4ZWzSh161uJpmQWEdKtT+Bzeg8zZ7+bZwwPGVD/rtvVu1yOnLL3rKU 6ZlXECXFmvVjZpQz2kIs= X-Received: by 2002:a63:4c5:0:b0:478:e150:e028 with SMTP id 188-20020a6304c5000000b00478e150e028mr11665029pge.284.1671098359335; Thu, 15 Dec 2022 01:59:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf49r/hKzBog4gfwhEDvr4c0VmQj8htARRMFOAZVXUR0Bw+ht7OTuJWrSB4FGKIC8BdCNuPH+V8We0cEWA7b3YA= X-Received: by 2002:a63:4c5:0:b0:478:e150:e028 with SMTP id 188-20020a6304c5000000b00478e150e028mr11665025pge.284.1671098359020; Thu, 15 Dec 2022 01:59:19 -0800 (PST) MIME-Version: 1.0 References: <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com> <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1670287169-15325-2-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 15 Dec 2022 10:59:07 +0100 Message-ID: Subject: Re: [PATCH 1/2] eal: add missing call marking memory config complete To: Tyler Retzlaff Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 6, 2022 at 1:39 AM Tyler Retzlaff wrote: > > Memory configuration was not being marked as completed add the missing > call to rte_eal_init() for Windows. > > Signed-off-by: Tyler Retzlaff The change is ok. The commitlog misses some context: I guess the point is to let rte_thread_register work on Windows. So we can mark this change as: Fixes: 5c307ba2a5b1 ("eal: register non-EAL threads as lcores") WDYT? In any case, this change won't fix anything related to mp. If mp is supported one day on Windows, other calls to eal_mcfg* would be required. -- David Marchand