From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, "Martin Spinler" <spinler@cesnet.cz>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Wathsala Vithanage" <wathsala.vithanage@arm.com>
Subject: Re: [PATCH] net/nfb: fix use after free
Date: Thu, 10 Oct 2024 19:17:19 +0200 [thread overview]
Message-ID: <CAJFAV8z04AWci67nHWXv=qG6_oj53njHqkjNVy1qvdmfG8WWog@mail.gmail.com> (raw)
In-Reply-To: <20241010171547.2510123-1-thomas@monjalon.net>
On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> With the annotations added to the allocation functions,
> more issues are detected at compilation time:
>
> nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free'
>
> It is fixed by moving the assignment before freeing the parent pointer.
>
> Fixes: 80da7efbb4c4 ("eal: annotate allocation functions")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2024-10-10 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 17:15 Thomas Monjalon
2024-10-10 17:17 ` David Marchand [this message]
2024-10-10 17:25 ` Thomas Monjalon
2024-10-11 11:50 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z04AWci67nHWXv=qG6_oj53njHqkjNVy1qvdmfG8WWog@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=spinler@cesnet.cz \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).