From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB97045B50; Wed, 16 Oct 2024 11:28:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75D6140144; Wed, 16 Oct 2024 11:28:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 074B240144 for ; Wed, 16 Oct 2024 11:28:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729070933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSLHYI1kdWzr28GDX+VSMCh7kTLoe3e2mu1jG/qGS+k=; b=iPl5+pEnYK2qwnYaSz2p/JSyDqa0bKhaXPg4KojB/+ktEPJA/SYFugtSjATxO1LWy1FZYY j+fvjIbeQFCu49491WTPr+SbAqnKT24eeLTD8bKGuXQ4qn8s+MLX3q2+qmKT4mhgKK+KI5 yYKeJID9anT7MAIINyn7ZsH69DTSCzw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-caBRNkJLPrOL6qTCM-z_CQ-1; Wed, 16 Oct 2024 05:28:52 -0400 X-MC-Unique: caBRNkJLPrOL6qTCM-z_CQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb384663aaso3512021fa.0 for ; Wed, 16 Oct 2024 02:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729070931; x=1729675731; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eSLHYI1kdWzr28GDX+VSMCh7kTLoe3e2mu1jG/qGS+k=; b=phCVDg1HA6lvYKnbksSPciI+OCukZvJivOYjX/l7nC7Udt9vsgqG+oSqYOCGwuZxVM MZyh/IfbS9rDDd7FZTgyQK1MoBqcX6e/v/r0vY2tNdHSJUWa0j46JU8qvOsNCe+XBXuP 43fRpMV64eURj2H+5O6REvxONYp8skkGdzUcRny5DmYO5kX4gvBuJFVKB6gY84HuYmQS XC+m+pM5gRas52kO+T1IDVm9+ky4exc3Vrvah2JImNSF4curDLn2VGUYajmqGg4BGhSy MDK64WrdUTIl6nSKYzDOsTkcz7jd0fC1knKIU/ODT83grGxW+fxRVRY3yOj6akivI3ft +Wig== X-Forwarded-Encrypted: i=1; AJvYcCVfVGjHJqU1xeoWfjy+pVwWG4n/7AdpSr72zoN+9d7yRBJqAo8BINoJ3oJvDlmr4QWPM+Q=@dpdk.org X-Gm-Message-State: AOJu0YyAXGjqsmX34slqoDgrGvMi+dpcNppx/ZKGP12DHlwlkJiFsO1u CY+z9e6fc6QIENwJh+lby0uAysWNoEU93dkNq8+lL6eGqHauTRlj+K/E/U/L7DxdXkF7gLw3SWc diODc2ZBJtdL1zJQvxJ6sLFH3p87SPjd4ryD/QW6eWV+Dx6u8Btv8ypaq/nUi5LAMmDGepgJqyQ I4SvhmogChrNLG4GI= X-Received: by 2002:a2e:a105:0:b0:2fb:4fd4:668a with SMTP id 38308e7fff4ca-2fb61bb1dbamr10914581fa.22.1729070930618; Wed, 16 Oct 2024 02:28:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2lTKITuRivVdopnEXBuAMQGjiyAFl8WoKtgcgBxxj1i40GJYxaMloP8ofEPe+fKZrlPiMXUg7hWQflMeiRj8= X-Received: by 2002:a2e:a105:0:b0:2fb:4fd4:668a with SMTP id 38308e7fff4ca-2fb61bb1dbamr10914521fa.22.1729070930191; Wed, 16 Oct 2024 02:28:50 -0700 (PDT) MIME-Version: 1.0 References: <20241015171143.497709-1-vladimir.medvedkin@intel.com> <20241015222938.359f7193@hermes.local> In-Reply-To: <20241015222938.359f7193@hermes.local> From: David Marchand Date: Wed, 16 Oct 2024 11:28:39 +0200 Message-ID: Subject: Re: [PATCH] fib: fix return value behavior To: Vladimir Medvedkin Cc: Stephen Hemminger , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 16, 2024 at 7:29=E2=80=AFAM Stephen Hemminger wrote: > On Tue, 15 Oct 2024 17:11:43 +0000 > Vladimir Medvedkin wrote: > > > Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its > > return value to align with the existing rte_fib API. > > > > Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation") > > > > Signed-off-by: Vladimir Medvedkin > Reviewed-by: Stephen Hemminger Applied, thanks. As Stephen noted, this new API needs better coverage. --=20 David Marchand