From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38DA9A0C4B; Tue, 2 Nov 2021 19:23:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C13954069F; Tue, 2 Nov 2021 19:23:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E0B7640689 for ; Tue, 2 Nov 2021 19:23:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635877383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/NSDxQDX2tPOMQoGN1JqFRbZJy0SOpWCxNWiB3uUAh8=; b=iVbS9fltzvxJcueJ+RXjBwzJFuBo44NfHsXSh+y6dOyxEczbJaagUn/MlNyfpypHk8P+BB vX3NNRfJTIlM0rE0Y9eTPNpzszs8oIjEyN5nDnQdZshyH+swe9iPF1E/OOI05Md96c+xWK DACkTAfMPP2QBL9C1gpajQIASgK58GI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-LsdNX23XOguwFoinwxxi4A-1; Tue, 02 Nov 2021 14:23:00 -0400 X-MC-Unique: LsdNX23XOguwFoinwxxi4A-1 Received: by mail-lj1-f200.google.com with SMTP id f17-20020a2e9751000000b00211a1367c68so8031944ljj.16 for ; Tue, 02 Nov 2021 11:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/NSDxQDX2tPOMQoGN1JqFRbZJy0SOpWCxNWiB3uUAh8=; b=l5DLrJ99TV+nJ2fYwwUbVSt4y7A3cn0GPNxu4iurDcBy4t28tbMfTPaerg4EXdy4F5 FRLWhs7qk+3syEmIDjmS8vnA59+fFGj8tvAUhkOuGBNVXPDfchzXXAQ1i91AZR62X0lk UEbwd7H4aybnA0gBi7JeBT2SSzvmTgtuKvJlvE+dXCBjd/zYnTqcmoLWFROXvuqT4Ysy RkXpI+NNMeaoibtog87xOoQhLIUQz+Se8hQrn6FxXlaalnbbHbLsuk0F/Ox0Snm70ok1 sK8LoSW/UqOcpH1BW0qzVsAu5UEtQHWQ+1tFvbiv7ajJxjNkHSrWooQ0tN42FiDVNiSo Ma7Q== X-Gm-Message-State: AOAM533XiirlOsPYINe5UfUBzdEMrwI/Vz94i0gINXYfVN1dTbyzUCnA f/K5yDRt/WDO2Wf2ij4VK7+MhYEUQgDSPsCgcioDgW72fRb8HEf7jdO8ee//69Yk/+AAGWStnip I9DZqkmWyXgGkv6p2EjI= X-Received: by 2002:a2e:901:: with SMTP id 1mr40801694ljj.333.1635877378398; Tue, 02 Nov 2021 11:22:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8swKjqILuepL7+h5Ln/KUx2h70Kl2uHExCLHTL2SO1PsECQZHXGMeKjOSMY3bKlJ7NIXoL0JHdKnif9gYBcw= X-Received: by 2002:a2e:901:: with SMTP id 1mr40801670ljj.333.1635877378168; Tue, 02 Nov 2021 11:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20211022205531.9966-1-david.marchand@redhat.com> <20211102111559.161c0914@hermes.local> In-Reply-To: <20211102111559.161c0914@hermes.local> From: David Marchand Date: Tue, 2 Nov 2021 19:22:46 +0100 Message-ID: To: Stephen Hemminger Cc: dev , Thomas Monjalon , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 2, 2021 at 7:16 PM Stephen Hemminger wrote: > > On Fri, 22 Oct 2021 22:55:31 +0200 > David Marchand wrote: > > > The rule for indentation in Meson in DPDK is 4 spaces. > > > > Any tab should be flagged as an issue, let's extend the check and fix > > existing offenders. > > > > Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") > > Fixes: 2457705e6474 ("crypto/cnxk: add driver skeleton") > > Fixes: 634b73104482 ("app/testpmd: build on Windows") > > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF") > > Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection") > > Fixes: e1369718f553 ("common/octeontx: enable build only on 64-bit Linux") > > Fixes: 2b504721bfda ("app/bbdev: enable la12xx") > > > > Signed-off-by: David Marchand > > There is also a new one in the dumpcap program, but can send follow on > for that one. > > Approved-by: Stephen Hemminger I am not aware of this form of tag, and patchwork does not recognise it either. Converted to usual ack. -- David Marchand