From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9C4142D8A; Thu, 29 Jun 2023 11:40:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BCD640EDB; Thu, 29 Jun 2023 11:40:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2864D406B7 for ; Thu, 29 Jun 2023 11:40:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688031606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/qGKqkmPVX3Oo+zupgfsQKa7J0MImdLh8pllEAgjFUY=; b=gttQJAjyiLOhm/09jWg35gPsMHK3ko2BOSr9SOiPkcup22pNgq2V51sG7UIGlUicV5KHWs kGZL0nogS6rigJ2HJ5tKed0apSLXEkmcjM4hpxg9N8+q1hwxQxL53QtJWpe51OCjAYYpek bKU3246xhmAx9Y9kdEJJzeKCMPKBE6I= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-b5Eh_MIaNl233xAnzJYzyg-1; Thu, 29 Jun 2023 05:40:05 -0400 X-MC-Unique: b5Eh_MIaNl233xAnzJYzyg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7624c3355baso69136485a.2 for ; Thu, 29 Jun 2023 02:40:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688031605; x=1690623605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qGKqkmPVX3Oo+zupgfsQKa7J0MImdLh8pllEAgjFUY=; b=Mq2W8nBx3McJa03xp+dWsP0mcz1iL7w+kfZb9MGFilBN/h9p7Frj2O87IxgFGtAIBC BsJSNFND+IqjcqUvei5BXlHINiZ1otq1TaWBDAVQQxBeQKKmVkjab0Ku7gYGlItSIZsi Ub2BlbDwgbX/Yrbb+vMNhyFc9vLzYjeYwDZDDMHyuFndRcziKiuIlBxKoIqaKNf2p1qD w2FnCAetQUhReqGoOyA3jJ5Y3uogSYZKBDX1NCmyPzH38USTbtE0yMjDWa2qdU4mrW9R YU1NdeMVB+mjY181ooRE9N/id8khN+JIg3TRbzFfkUfArgnjmlXjv/CvENeVIoEnfG/j +T2Q== X-Gm-Message-State: AC+VfDytjsJJaUAw8qI44/EMAHIEXG3D7hnoBSZrqhuXzffekgG9Tzwg trQYoSnHDM43AaXFgKc3rroKibrjrcMXK6zcGrxIzqsbRUOnX0YgJzeuolDbMF/wYMPd4PR6YvB lSv1SLd9IGLVEQNDATss= X-Received: by 2002:a37:f70a:0:b0:765:5ba6:a5ce with SMTP id q10-20020a37f70a000000b007655ba6a5cemr12357927qkj.45.1688031604997; Thu, 29 Jun 2023 02:40:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5CbAPTqtJk8yv6h5N4oMQz8mejKx/qnSegLOY/SROHTpX3XjT6pp1Q3xJUWpq69dGlzsRTgQfkyw/gCJeuGh8= X-Received: by 2002:a37:f70a:0:b0:765:5ba6:a5ce with SMTP id q10-20020a37f70a000000b007655ba6a5cemr12357921qkj.45.1688031604765; Thu, 29 Jun 2023 02:40:04 -0700 (PDT) MIME-Version: 1.0 References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> <20230623150708.2203918-3-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Thu, 29 Jun 2023 11:39:53 +0200 Message-ID: Subject: Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib To: Bruce Richardson Cc: dev@dpdk.org, Timothy McDaniel X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 28, 2023 at 12:19=E2=80=AFPM David Marchand wrote: > > On Fri, Jun 23, 2023 at 5:07=E2=80=AFPM Bruce Richardson > wrote: > > > > While the build system will skip building most libs and drivers when a > > dependency is missing for a component, for DLB2 driver, the > > "static_rte_eventdev" object is referenced inside the meson.build file > > itself, which will cause crashes if it doesn't exist i.e. if eventdev i= s > > disabled. Prevent this issue by skipping processing the file if no > > eventdev. [The build system will still report missing dependency, as th= e > > dependency is set by default for all eventdev drivers] > > > > Signed-off-by: Bruce Richardson > > Could we evaluate the class "std_deps" before jumping to each driver > meson.build? Hum, with my suggestion, we lose the opportunity for drivers to rewrite completely their "deps". I doubt we have cases where it really matters, but if this revealed to be necessary, such driver may be directly referenced in drivers/meson.build like we do for common/cnxk & friends. To illustrate the idea, I pushed your series along patches of mine (target is v23.11) in my github repo. https://github.com/david-marchand/dpdk/commit/enable_libs~8 --=20 David Marchand