From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
[209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 0B16F4F90
for <dev@dpdk.org>; Thu, 2 May 2019 14:21:11 +0200 (CEST)
Received: by mail-vs1-f66.google.com with SMTP id v141so1221915vsc.5
for <dev@dpdk.org>; Thu, 02 May 2019 05:21:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=q/XRVlxQl3Pl7njqrCQsvsZTVCfCAO/Fk6Xlaxq8c0M=;
b=gfYqLvJhv2njj5Vn+7Uz6zVPDvCCJeV0py8a+xUJCwCEaZ1ViPInCBYRtpK1qupYHN
8SLw53nfZTgx0xtXOm+7RD/Mbj0JX0aRspzvWf9CWGf07YOWKwa7s3koIvmB0fFfoud8
ZLYdC23QzAhKZgYgF4/9njvB+8H60ON1Wjh5jPKttIvacbQNkzqCl7NLv5NyVvjFQ1UJ
ELNQ5D0NmLMVaa8eIym103fvd/DOlIdfDtge+Kdw4OBK1ZebBF9Sw2H2Tgj3wK4lt0Ek
aAXIWOyI3iZ9XpVojKbQY5T9L3HvjPJkt7Cvj7XkLh2xejNDrKDlTujAHEsi4QYPOaDp
MQ3Q==
X-Gm-Message-State: APjAAAXQQ9ByPeeMZUKO9uHdUBAZmanXKve921j36kd6TyXRbKVPM3jw
Mh/OvbE0KzVULKmYZF9g+uwY3twrKpROkUjQsWvaCker
X-Google-Smtp-Source: APXvYqyE4waCAN503CKsGBtRg3ZsLiaGPCxqsNlNltRDEFlEU3vxACKs23bhuLgGzvEHnmd2O9aYq7oQR+42zBjb8+c=
X-Received: by 2002:a67:a446:: with SMTP id p6mr1857195vsh.198.1556799670469;
Thu, 02 May 2019 05:21:10 -0700 (PDT)
MIME-Version: 1.0
References: <20190501195014.2938-1-bruce.richardson@intel.com>
<20190501195014.2938-2-bruce.richardson@intel.com>
In-Reply-To: <20190501195014.2938-2-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 2 May 2019 14:20:59 +0200
Message-ID: <CAJFAV8z1=HJ_ctmFGPpduZ0XV4zZ_T_VFEDXLCFAwbzL3JCffA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, vladz@cloudius-systems.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC 9 on
Fedora 30
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 May 2019 12:21:11 -0000
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson <bruce.richardson@intel.com=
>
wrote:
> Compiling on Fedora 30, we get the following warning, causing build failu=
re
> when Werror flag is set:
>
> ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: =E2=80=98nmb=E2=80=99=
may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> 2141 | rxe->mbuf =3D nmb;
> | ~~~~~~~~~~^~~~~
>
> Initializing the value to "NULL" fixes the issue.
>
> Fixes: 8eecb3295aed ("ixgbe: add LRO support")
> Cc: vladz@cloudius-systems.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e71d3c188..1fbc754ae 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2029,7 +2029,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf
> **rx_pkts, uint16_t nb_pkts,
> struct ixgbe_rx_entry *next_rxe =3D NULL;
> struct rte_mbuf *first_seg;
> struct rte_mbuf *rxm;
> - struct rte_mbuf *nmb;
> + struct rte_mbuf *nmb =3D NULL;
> union ixgbe_adv_rx_desc rxd;
> uint16_t data_len;
> uint16_t next_id;
> --
> 2.21.0
>
>
Tested-by: David Marchand <david.marchand@redhat.com>
--=20
David Marchand
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 4CD69A0AC5
for <public@inbox.dpdk.org>; Thu, 2 May 2019 14:21:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 1DE4D5A44;
Thu, 2 May 2019 14:21:12 +0200 (CEST)
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
[209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 0B16F4F90
for <dev@dpdk.org>; Thu, 2 May 2019 14:21:11 +0200 (CEST)
Received: by mail-vs1-f66.google.com with SMTP id v141so1221915vsc.5
for <dev@dpdk.org>; Thu, 02 May 2019 05:21:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=q/XRVlxQl3Pl7njqrCQsvsZTVCfCAO/Fk6Xlaxq8c0M=;
b=gfYqLvJhv2njj5Vn+7Uz6zVPDvCCJeV0py8a+xUJCwCEaZ1ViPInCBYRtpK1qupYHN
8SLw53nfZTgx0xtXOm+7RD/Mbj0JX0aRspzvWf9CWGf07YOWKwa7s3koIvmB0fFfoud8
ZLYdC23QzAhKZgYgF4/9njvB+8H60ON1Wjh5jPKttIvacbQNkzqCl7NLv5NyVvjFQ1UJ
ELNQ5D0NmLMVaa8eIym103fvd/DOlIdfDtge+Kdw4OBK1ZebBF9Sw2H2Tgj3wK4lt0Ek
aAXIWOyI3iZ9XpVojKbQY5T9L3HvjPJkt7Cvj7XkLh2xejNDrKDlTujAHEsi4QYPOaDp
MQ3Q==
X-Gm-Message-State: APjAAAXQQ9ByPeeMZUKO9uHdUBAZmanXKve921j36kd6TyXRbKVPM3jw
Mh/OvbE0KzVULKmYZF9g+uwY3twrKpROkUjQsWvaCker
X-Google-Smtp-Source: APXvYqyE4waCAN503CKsGBtRg3ZsLiaGPCxqsNlNltRDEFlEU3vxACKs23bhuLgGzvEHnmd2O9aYq7oQR+42zBjb8+c=
X-Received: by 2002:a67:a446:: with SMTP id p6mr1857195vsh.198.1556799670469;
Thu, 02 May 2019 05:21:10 -0700 (PDT)
MIME-Version: 1.0
References: <20190501195014.2938-1-bruce.richardson@intel.com>
<20190501195014.2938-2-bruce.richardson@intel.com>
In-Reply-To: <20190501195014.2938-2-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 2 May 2019 14:20:59 +0200
Message-ID:
<CAJFAV8z1=HJ_ctmFGPpduZ0XV4zZ_T_VFEDXLCFAwbzL3JCffA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, vladz@cloudius-systems.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC 9 on
Fedora 30
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190502122059.SpSjmH1eDg0QhT64KDkBlCIXcr0DLlO8kWj29NPxsBU@z>
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson <bruce.richardson@intel.com=
>
wrote:
> Compiling on Fedora 30, we get the following warning, causing build failu=
re
> when Werror flag is set:
>
> ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: =E2=80=98nmb=E2=80=99=
may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> 2141 | rxe->mbuf =3D nmb;
> | ~~~~~~~~~~^~~~~
>
> Initializing the value to "NULL" fixes the issue.
>
> Fixes: 8eecb3295aed ("ixgbe: add LRO support")
> Cc: vladz@cloudius-systems.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e71d3c188..1fbc754ae 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2029,7 +2029,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf
> **rx_pkts, uint16_t nb_pkts,
> struct ixgbe_rx_entry *next_rxe =3D NULL;
> struct rte_mbuf *first_seg;
> struct rte_mbuf *rxm;
> - struct rte_mbuf *nmb;
> + struct rte_mbuf *nmb =3D NULL;
> union ixgbe_adv_rx_desc rxd;
> uint16_t data_len;
> uint16_t next_id;
> --
> 2.21.0
>
>
Tested-by: David Marchand <david.marchand@redhat.com>
--=20
David Marchand