From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F01C9436D3; Tue, 12 Dec 2023 16:00:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97AAF40278; Tue, 12 Dec 2023 16:00:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3123840270 for ; Tue, 12 Dec 2023 16:00:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702393250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5umnIjuF46sTSfFqt0NGFGCv3+9X8uE88uRRc28QzUQ=; b=B1t+DNtHmG0jziH0MNGhdhNqoEw2RSn1swZpFUGPgdk0QMZPas+/g0W7zLk/2ZJeSQQYfR dQVWOhH7NU3iv8lZBcEZ1un2owpjI7mtM6GpJjZLjbHcKhPJlWX5/IFoXM1Okq0ntavYyf ZQ9N6wO2GAmS1ClZW0Gc2DY5yLMgzKg= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-v1NQo12qNE6bFqXh-xDllg-1; Tue, 12 Dec 2023 10:00:49 -0500 X-MC-Unique: v1NQo12qNE6bFqXh-xDllg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ca23b6f61eso32945161fa.1 for ; Tue, 12 Dec 2023 07:00:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702393247; x=1702998047; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5umnIjuF46sTSfFqt0NGFGCv3+9X8uE88uRRc28QzUQ=; b=QRJxD55Yz/PfjEOypEXsMf820eJnqGx2mpVEc4dw9tQ7aGJxqY4/K6h+RnJUhFysGD HJvh2dwF7GqsjhQmeg+XcSULBbXGJyH4C1Wa2YTLOwdPS19PyolTrrNsj1xOFQtwwg73 //OXFMlnhm8fwGwTud82pGj3envdapaASVFy7LSALZ+kmPWtJJegGG8v2kZ1guDIHi+T 3ikD+k0QWXWdsrekoClLzNzq4JExYMq05Wz76IDNaAgCqOfJDjJRB2KEY/QcVP05AdPP K4cb6AuqKLIS+wRwWhgP3z5zNziEMmfGg3c3MWkwGtamvfFtut2lOwOfdyz8outX7TG8 rmBA== X-Gm-Message-State: AOJu0YwllEvbwnM1cj3ojaolnXgdem3WpZZN35TNdGKEDAU6f3cBDfBN uF6RjKbPyQ4hxjtXpn30Vc/RxDK6rN6yxMhrVp+cjK/I5IvJ0Dir38Xcu0Nv71VPdhVku0HHuf3 ZEY9bV3px0CBeYnbZtmU= X-Received: by 2002:a05:651c:211a:b0:2cb:27ef:c665 with SMTP id a26-20020a05651c211a00b002cb27efc665mr3716495ljq.10.1702393247625; Tue, 12 Dec 2023 07:00:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IH24YTOzaaZufeCiEWnkavBY7EQStb3+ffxgn2u3u7zWCECGVDztad8boB4VsOy2ytysKaKBn0pWONVbx41FTw= X-Received: by 2002:a05:651c:211a:b0:2cb:27ef:c665 with SMTP id a26-20020a05651c211a00b002cb27efc665mr3716481ljq.10.1702393247278; Tue, 12 Dec 2023 07:00:47 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-10-david.marchand@redhat.com> <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 12 Dec 2023 16:00:35 +0100 Message-ID: Subject: Re: [RFC v2 09/14] rcu: introduce a logging helper To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Honnappa Nagarahalli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 8, 2023 at 10:27=E2=80=AFPM Tyler Retzlaff wrote: > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > Signed-off-by: David Marchand > > --- > > Reviewed-by: Tyler Retzlaff > > > lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++-------------------------- > > lib/rcu/rte_rcu_qsbr.h | 1 + > > 2 files changed, 24 insertions(+), 39 deletions(-) > > > > diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c > > index 41a44be4b9..5b6530788a 100644 > > --- a/lib/rcu/rte_rcu_qsbr.c > > +++ b/lib/rcu/rte_rcu_qsbr.c > > @@ -19,6 +19,9 @@ > > #include "rte_rcu_qsbr.h" > > #include "rcu_qsbr_pvt.h" > > > > +#define RCU_LOG(level, fmt, args...) \ > > + RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args) > > + > > Since you are looking in the area for all the versions of gcc/clang we > use able to support the non-standard __VA_ARGS__ that discard the comma? I suspect there is some typo (maybe s/for all/are all/ ?). Can you please clarify? > > I know that some versions of gcc do and if it does I would like to move > to using __VA_ARGS__ instead of args so we can use the same thing with > msvc. If the request is to translate the ## args stuff to __VA_ARGS__, I would prefer this is done in a separate series and not to mix with this already huge series. --=20 David Marchand