DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Balazs Nemeth <bnemeth@redhat.com>
Cc: dev <dev@dpdk.org>, Wei Ling <weix.ling@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index
Date: Sat, 15 May 2021 08:10:05 +0200	[thread overview]
Message-ID: <CAJFAV8z1swkm9neeNrdem_KSCfJECsuQkYX6mk7xEENeO2SvjQ@mail.gmail.com> (raw)
In-Reply-To: <83fa6253725a7bc69bccb7897f380422354a2898.1621008025.git.bnemeth@redhat.com>

On Fri, May 14, 2021 at 6:02 PM Balazs Nemeth <bnemeth@redhat.com> wrote:
>
> The optimization introduced by commit d18db8049c7c ("vhost: read last
> used index once") didn't account for the fact that
> vhost_flush_enqueue_shadow_packed increments the last_used_idx. For this
> reason, store last_used_idx after the potential call to
> vhost_flush_enqueue_shadow_packed.
>

Bugzilla ID: 699
> Fixes: d18db8049c7c ("vhost: read last used index once")

> Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2021-05-15  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 16:02 Balazs Nemeth
2021-05-15  6:10 ` David Marchand [this message]
2021-05-17  7:37 ` Maxime Coquelin
2021-05-17 10:07   ` Ling, WeiX
2021-05-17 10:46     ` Maxime Coquelin
2021-05-18  8:03 ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8z1swkm9neeNrdem_KSCfJECsuQkYX6mk7xEENeO2SvjQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bnemeth@redhat.com \
    --cc=dev@dpdk.org \
    --cc=weix.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).