From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBB87426CF; Fri, 6 Oct 2023 13:06:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F1E0402B9; Fri, 6 Oct 2023 13:06:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C22DD402A8 for ; Fri, 6 Oct 2023 13:06:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696590415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mPYIzio8Zwz2GgbY4PFtXKzn4PRB393ZzOUpae2qscg=; b=SE3LBpGov21YxxqFFHh5a+iCrLYnTJ9daRleAq86FGyUgmMmVR59F9ScUMYHZz2lm29rPe emuVtN7CkvucDTU1iKUrkZpK/9Xmlg2VTEcjEf5k4tC1kLfkkHxCxVwlBbKNPD964TQvRF T2yCxg6ri9SBzOf9OJPdRlPAFkGlSpA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-FoiSv_zsNI2SG5aGtmFDCQ-1; Fri, 06 Oct 2023 07:06:53 -0400 X-MC-Unique: FoiSv_zsNI2SG5aGtmFDCQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5043353efbdso1900449e87.0 for ; Fri, 06 Oct 2023 04:06:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696590412; x=1697195212; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mPYIzio8Zwz2GgbY4PFtXKzn4PRB393ZzOUpae2qscg=; b=ewAS0fNphgBzcBLPUIxt1lFFyzQOA7El1pO2wU7fJ7kkqIlhbg8d9/e0GArrmzd4kK 5xd9oHpOE0LaL2P9Rz7y0VXdpE23qGUfIf6u2sT3zNRVp6yy3ArqhAJ+A3LubBuk6mQF ACr8zoq5jMS+T8fqySu+A0q2+3k6vXQOrmBsF8FXD0Uhtdjl0v31KgAw3MuD1pK6ua7H E/CYjuqw3nF0Ksih1J2lbgiJaBXuQdTUS0A3JKKWaXZkFkRV3WUf618+T7mBxtQmdX7m sq1G+/hexO4ycBtYiWQKIaoM3R4iLG5yyA0ELshlkb7bsHj3l5hmBh7YloCx6zRDrU7h fnXw== X-Gm-Message-State: AOJu0YwRBqS1XKvyupq5rCmQTGeR9wrWPceUSd0KKeuzj9xlr5Yriitn SO51Anbw4yxnmXbtF7pT0Mxlq1oH2PMUC6p60pgOUaZQYI72ynF5z6lTOzSWxStIG3I8EJLwscU DWwqxtdJ3x6/htHDJCNs= X-Received: by 2002:a05:6512:2152:b0:504:7f58:6dfd with SMTP id s18-20020a056512215200b005047f586dfdmr5558727lfr.2.1696590412502; Fri, 06 Oct 2023 04:06:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwd/3I7qH4KgxPsyNvHtNkLn5DQaUCD/TDWAD1+RWG5uHuUTTNWhfbHM6eIdRMsZvtbgjDT9gJ5BzjLVsYsPA= X-Received: by 2002:a05:6512:2152:b0:504:7f58:6dfd with SMTP id s18-20020a056512215200b005047f586dfdmr5558711lfr.2.1696590412211; Fri, 06 Oct 2023 04:06:52 -0700 (PDT) MIME-Version: 1.0 References: <20210719044624.3604232-1-asomalap@amd.com> <20210726090821.3833862-1-asomalap@amd.com> In-Reply-To: <20210726090821.3833862-1-asomalap@amd.com> From: David Marchand Date: Fri, 6 Oct 2023 13:06:40 +0200 Message-ID: Subject: Re: [dpdk-dev] [PATCH v6] crypto/ccp: move device from vdev to PCI To: Sunil Uttarwar Cc: dev@dpdk.org, asomalap@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Sunil, On Mon, Jul 26, 2021 at 11:09=E2=80=AFAM wrote: > > From: Amaranath Somalapuram > > drop all the code duplicating the PCI bus driver > developed for enable IOMMU in vdev. > > Signed-off-by: Amaranath Somalapuram Looking back in history, this patch converted crypto/ccp to a PCI driver, but the associated doc is still about vdev. https://doc.dpdk.org/guides/cryptodevs/ccp.html#initialization And I also noticed some remnants, like: drivers/crypto/ccp/meson.build:deps +=3D 'bus_vdev' drivers/crypto/ccp/rte_ccp_pmd.c:#include drivers/crypto/ccp/rte_ccp_pmd.c: CCP_LOG_ERR("failed to create cryptodev vdev"); Can you send fixes? Thanks. --=20 David Marchand