From: David Marchand <david.marchand@redhat.com>
To: Srujana Challa <schalla@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"chenbox@nvidia.com" <chenbox@nvidia.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA
Date: Fri, 12 Jul 2024 09:57:20 +0200 [thread overview]
Message-ID: <CAJFAV8z3-vWvykfyj2LLLNXPWcrbGhx==E7wE2Zxbr9wJsg2+g@mail.gmail.com> (raw)
In-Reply-To: <DS0PR18MB53681B2533173ADB9258050DA0A52@DS0PR18MB5368.namprd18.prod.outlook.com>
On Thu, Jul 11, 2024 at 7:46 PM Srujana Challa <schalla@marvell.com> wrote:
> > > +963,8 @@ virtio_user_handle_ctrl_msg_split(struct virtio_user_dev *dev,
> > struct vring *vri
> > > (struct virtio_pmd_ctrl *)hdr, dlen,
> > > nb_dlen);
> > >
> > > /* Update status */
> > > - *(virtio_net_ctrl_ack *)virtio_user_iova2virt(vring-
> > >desc[idx_status].addr) = status;
> > > + *(virtio_net_ctrl_ack *)
> > > + virtio_user_iova2virt(vring->desc[idx_status].addr,
> > > + use_va) = status;
> >
> > Afaics, no need for reindenting.
> It crossed 100 line boundary actually.
Ah indeed, it is crossed with "use_va".
But it won't be the case when passing dev.
So please don't touch original indent after applying my suggestion.
--
David Marchand
next prev parent reply other threads:[~2024-07-12 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 12:44 Srujana Challa
2024-07-11 15:02 ` David Marchand
2024-07-11 17:46 ` [EXTERNAL] " Srujana Challa
2024-07-12 7:57 ` David Marchand [this message]
2024-07-12 11:30 ` David Marchand
2024-07-12 11:51 ` Srujana Challa
2024-07-12 12:36 ` [PATCH v3] net/virtio_user: fix cq descriptor conversion with non vDPA backend Srujana Challa
2024-07-12 14:24 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z3-vWvykfyj2LLLNXPWcrbGhx==E7wE2Zxbr9wJsg2+g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=schalla@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).