DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	 Akhil Goyal <gakhil@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 Maxime Coquelin <maxime.coquelin@redhat.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Raslan Darawsheh <rasland@nvidia.com>
Cc: dev@dpdk.org, Ilya Maximets <i.maximets@ovn.org>,
	Michael Santana <msantana@redhat.com>,
	 Thomas Monjalon <thomas@monjalon.net>,
	Kevin Traynor <ktraynor@redhat.com>,
	 Luca Boccassi <bluca@debian.org>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>
Subject: Re: [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.
Date: Wed, 13 Mar 2024 13:11:30 +0100	[thread overview]
Message-ID: <CAJFAV8z3aoEbHtzAC_4Wf_Pmkp5pYZTYc-ZaOSC0AFDDsPfjgA@mail.gmail.com> (raw)
In-Reply-To: <20240312145326.1377818-1-aconole@redhat.com>

On Tue, Mar 12, 2024 at 3:53 PM Aaron Conole <aconole@redhat.com> wrote:
>
> GitHub recently started using newer Ubuntu 22.04 LTS container images,
> versioned 20240310.1.0 which use 32-bit entropy for ASLR:
>
>   $ sudo sysctl -a | grep vm.mmap.rnd
>   vm.mmap_rnd_bits = 32
>   vm.mmap_rnd_compat_bits = 16
>
> This breaks builds (such as the one at
> https://github.com/DPDK/dpdk/actions/runs/8234334617/job/22515850325) by
> causing a random segfault when ASAN is used, because older ASAN gets
> confused by memory mappings and crashes.
>
> The issue is fixed in newer releases of LLVM:
>   https://github.com/llvm/llvm-project/commit/fb77ca05ffb4f8e666878f2f6718a9fb4d686839
>   https://reviews.llvm.org/D148280
>
> But these are not available in Ubuntu 22.04 image.
>
> This should be fixed by GitHub, but until new images are available
> reducing ASLR entropy manually to 28 bits to make builds work.
>
> Reported-at: https://github.com/actions/runner-images/issues/9491
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Suggested-by: Ilya Maximets <i.maximets@ovn.org>

Thanks Aaron, I applied this workaround for now.

Heads up to subtree maintainers.
We have some false positive test failures in GHA for the past days.
Please rebase to DPDK main repository or pick this fix in your trees.


Thanks.

-- 
David Marchand


  reply	other threads:[~2024-03-13 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 14:53 Aaron Conole
2024-03-13 12:11 ` David Marchand [this message]
     [not found] <20240312114750.68295-1-i.maximets@ovn.org>
2024-03-12 13:28 ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8z3aoEbHtzAC_4Wf_Pmkp5pYZTYc-ZaOSC0AFDDsPfjgA@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=gakhil@marvell.com \
    --cc=i.maximets@ovn.org \
    --cc=jerinj@marvell.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=msantana@redhat.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).