From: David Marchand <david.marchand@redhat.com>
To: Andrzej Ostruszka <aostruszka@marvell.com>
Cc: dev <dev@dpdk.org>, David Hunt <david.hunt@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Robert Sanford <rsanford@akamai.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Marcin Baran <marcinx.baran@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] build: remove unused function versioning
Date: Wed, 5 Feb 2020 21:44:28 +0100 [thread overview]
Message-ID: <CAJFAV8z4eEad+i371ipyB61bkxKTuQ-cfWPoe1zqSBBUGKoNaA@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8yoaD79ZAvA-yKJPVWZosGY+yECdkUnvMUMKDTdexm7Dg@mail.gmail.com>
On Thu, Jan 30, 2020 at 5:11 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Jan 30, 2020 at 10:25 AM Andrzej Ostruszka
> <aostruszka@marvell.com> wrote:
> >
> > Timer, LPM and Distributor libraries no longer use function versioning
> > and therefore do not need separate build for static and shared version
> > of libraries.
> >
> > This patch removes use_function_versioning from their meson build files
> > and corresponding include from the sources.
> >
> > Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Fixes: f2fb215843a9 ("timer: remove deprecated code")
> > Fixes: 6e5b51676176 ("distributor: remove deprecated code")
> > Fixes: c381a8d554b7 ("lpm: remove deprecated code")
> > Cc: marcinx.baran@intel.com
> >
> > ---
> > V2:
> > - removed also includes (updating only meson files causes build
> > failures), and updated commit msg accordingly
>
> Thanks, I had the exact same patch in store (caught when working with
> Olivier on some ABI stuff for mempool).
>
> Cc: stable@dpdk.org
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-02-05 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 16:23 [dpdk-dev] [PATCH] build: remove function versioning from meson files Andrzej Ostruszka
2020-01-29 16:30 ` Richardson, Bruce
2020-01-30 9:25 ` [dpdk-dev] [PATCH v2] build: remove unused function versioning Andrzej Ostruszka
2020-01-30 16:11 ` David Marchand
2020-02-05 20:44 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z4eEad+i371ipyB61bkxKTuQ-cfWPoe1zqSBBUGKoNaA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aostruszka@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=marcinx.baran@intel.com \
--cc=rsanford@akamai.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).