Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is disabled

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 29, 2019 at 10:36 AM Pattan, Reshma <reshma.pattan@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Sunday, October 27, 2019 8:48 AM
> > To: Pattan, Reshma <reshma.pattan@intel.com>
> > Cc: dev <dev@dpdk.org>; dpdk stable <stable@dpdk.org>; Rao, Nikhil
> > <nikhil.rao@intel.com>; Chas Williams <chas3@att.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; Stephen Hemminger
> > <stephen@networkplumber.org>
> > Subject: Re: [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is
> > disabled
> >
> > On Fri, Oct 25, 2019 at 5:38 PM Reshma Pattan <reshma.pattan@intel.com>
> > wrote:
> > >
> > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter unit
> > > tests are dependent on ring PMD, so compile those tests only when ring
> > > PMD is enabled else ignore.
> > >
> > > 2)get rid of make file error which was added by bond unit test for
> > > ring PMD disabled case which is not necessary.
> > >
> > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> > > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
> > > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats
> > > library")
> > > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
> > > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")
> > >
> > > CC: stable@dpdk.org
> > > CC: Nikhil Rao <nikhil.rao@intel.com>
> > > CC: Chas Williams <chas3@att.com>
> > > CC: Bruce Richardson <bruce.richardson@intel.com>
> > > CC: Stephen Hemminger <stephen@networkplumber.org>
> > >
> > > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > > ---
> > > v3: add missing test event_eth_tx_adapter_autotest.
> >
> > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
> >
> > 79/83 DPDK:fast-tests / event_eth_tx_adapter_autotest  FAIL     0.12 s
> > (exit status 255 or signal 127 SIGinvalid)
> > --- command ---
> > DPDK_TEST='event_eth_tx_adapter_autotest'
> > /home/travis/build/ovsrobot/dpdk/build/app/test/dpdk-test -l 0-1 --file-
> > prefix=event_eth_tx_adapter_autotest
> > --- stdout ---
> > EAL: Probing VFIO support...
> > APP: HPET is not enabled, using TSC as default timer
> > RTE>>event_eth_tx_adapter_autotest
> >  + ------------------------------------------------------- +  + Test Suite : tx event eth
> > adapter test suite Port 0 MAC: 00 00 00 00 00 00 Port 1 MAC: 00 00 00 00 00 00
> > Failed to find a valid event device, testing with event_sw0 device  + ----------------
> > --------------------------------------- +  + Test Suite Summary
> >  + Tests Total :        5
> >  + Tests Skipped :      0
> >  + Tests Executed :     0
> >  + Tests Unsupported:   0
> >  + Tests Passed :       0
> >  + Tests Failed :       5
> >  + ------------------------------------------------------- + Test Failed
> >
>
> Is this something that Nikhil should look into this as maintainer and fix in separate patch, I am afraid this is not my area of expertise.

I agree that someone knowing of this test should be looking at it.

My suggestion on adding this test was based on the fact that we were
building this code test.
But I was expecting that you test this addition.

You shall not break the CI :-)
Please add this to your checklist for future submissions, or at least
check the robot reports.


Thanks.

-- 
David Marchand