From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0781CA046B for ; Thu, 27 Jun 2019 09:37:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3B62F04; Thu, 27 Jun 2019 09:37:28 +0200 (CEST) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by dpdk.org (Postfix) with ESMTP id CDC28DED for ; Thu, 27 Jun 2019 09:37:27 +0200 (CEST) Received: by mail-ua1-f51.google.com with SMTP id s4so479313uad.7 for ; Thu, 27 Jun 2019 00:37:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BPJS+shAqmZKrmxHPQXl/+o7ds2Jv91Ky2stJZv1El0=; b=NdjkxiG0WNxseSRkP6Siu76TkzIl2lvAVafK8qRCso9zvs9B5gHSE++ocV42oppxQp scuuqzxvIygF2LmjDuyb7ZcbWREewO0m0jIxRwM/n6+vO8Jhr9+z+wi8T0xUcmuasSIZ 7EzWok/KihaDuYrj10rdp8mkEMVTDd3ZLN/bVzxTHcyvk0dM654Hce35gb+gQqVAlVxR QrxAjfyqp0+s9FViZSD7T3t3dDrqVivbHSsXHZOzgiuLvDDaYlLI2rRdLF2YJ2tQLMap pRMQhLohVw3n9YuDM62/QPEcvJa7FfINF5zjlJ4dHTnErQoXjuCCwpNjK3CitcK4R0Gs X7pQ== X-Gm-Message-State: APjAAAWcCCURObGwpjIS1cNsOxIGj85ZQeDHMoPdo1u3agEEAef2giUV M5sYEqmMXAqrBV6eikubDli1Oqxic/fAM5TFi4bwDg== X-Google-Smtp-Source: APXvYqz9Hg/YCWUoj4al8cVvc9I2M/HoM00XjbGrIlUWi+4HxWluJoCirC95GOZsbaFLRlN7AY5qLvQEv2thFS8swWE= X-Received: by 2002:ab0:2bc6:: with SMTP id s6mr1478890uar.86.1561621047173; Thu, 27 Jun 2019 00:37:27 -0700 (PDT) MIME-Version: 1.0 References: <20190606100228.19959-1-i.maximets@samsung.com> <6761573.WUIlbu0Kbq@xps> In-Reply-To: <6761573.WUIlbu0Kbq@xps> From: David Marchand Date: Thu, 27 Jun 2019 09:37:16 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Ilya Maximets , Anatoly Burakov , Jan Blunck , Qi Zhang , Kevin Traynor , dpdk stable , Gaetan Rivet Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 26, 2019 at 11:03 PM Thomas Monjalon wrote: > 07/06/2019 10:32, David Marchand: > > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > > wrote: > > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > > return 0 or negative error code. Bus code returns positive values > > > if device wasn't recognized by any driver, so the result of > > > 'bus->plug/unplug()' must be converted. 'local_dev_probe()' and > > > 'local_dev_remove()' also has their internal API, so the conversion > > > should be done there. > > > > > > Positive on remove means that device not found by driver. > > > > > > > For backports, it is safer to add the check on > 0. > > The patch looks good to me. > > > > Reviewed-by: David Marchand > > I did not get your comment. Is it OK to get this v2? > What do you mean about backports? > > Yes this v2 is ok. I wanted to dissociate from my other comments which would not be part of the fix for stable. -- David Marchand