From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71CBAA0547; Thu, 28 Oct 2021 14:38:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C56C4111A; Thu, 28 Oct 2021 14:38:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4069240DF4 for ; Thu, 28 Oct 2021 14:38:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635424730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vHIbFo0Zk4CoxrpCbDe4w0CP7EHqebYeJM3b4o0F4vw=; b=cIPVNP+UM6EcCIYfhs1BEn8mq662caino4ixshhDPCMs1fSJ6YJCxeBZaq4OeKWFPqFq0B EYTOR8uMUkeGbltjF6a3dSV2fh+6o2Q/qAdS3j7Ycv7L09nHlzrWknYvpgSfurBbbYKQIi 1E3H4KXAXeqr73ZRVHhQiFNC/gk+hWM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-50-4aOlRtAvOQ634lSeQ_j9Lw-1; Thu, 28 Oct 2021 08:38:46 -0400 X-MC-Unique: 4aOlRtAvOQ634lSeQ_j9Lw-1 Received: by mail-lj1-f197.google.com with SMTP id y18-20020a2e7d12000000b00212b22bc3a4so508267ljc.2 for ; Thu, 28 Oct 2021 05:38:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHIbFo0Zk4CoxrpCbDe4w0CP7EHqebYeJM3b4o0F4vw=; b=3q4aZpcKqtp2rkn1y8WKq/QuPv/Xch2OHitebOXd8P2wIRotYomxCBghswb/GtHItE zTmf47RifpAzyH7e/IZ/ESpBRVhIizyqXKv5H/E67wa01qSmQXQm8l3vN7FSmFHSiM5y 5copvaKP06eAcaSfhLsfOP/Kp9lTlNUQuiHgQmmIpF9IVArlRT71RoX7iKdpQc5CMN/K LUnvt9onhuo2fNUaLzPJWsdoXAkdLQJlsUl0aPrvKD1G1gLloYWVn6xG4xKLvz3iFATC 4aNHDBi2iBFQ3F/dVrxRH0+VDZLUIEYbeUxk9TgZnHoB6L6fWw7JySzPwwypZsL447nP dZUA== X-Gm-Message-State: AOAM533gcj3Oqm5Ourr+zYxX41wPGGKlMAPSJ/yXLgqO8I/QksIck0qr R5OWUVDqrKSsvYraUZc3nLfEUwm5fMycMt0K3/NqsLbHUgu/wodc1oOEAT2TJQWcRLf/IZxnMOv XUJ3DhqfqF722R8xKtvc= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr3817077lfq.553.1635424724903; Thu, 28 Oct 2021 05:38:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0VHM3WvCJ0D31JY6baI5vg6xGCeqfWayzKubcjI1TuuDr720btcb+OckFjOMCazz/WCmUN5FL3jLrPYtBSZ8= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr3817041lfq.553.1635424724599; Thu, 28 Oct 2021 05:38:44 -0700 (PDT) MIME-Version: 1.0 References: <20211028120329.44710-1-maxime.coquelin@redhat.com> In-Reply-To: <20211028120329.44710-1-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 28 Oct 2021 14:38:33 +0200 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , "Xueming(Steven) Li" , Xiao Wang , techboard@dpdk.org, Thomas Monjalon , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] vhost: mark vDPA driver API as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 28, 2021 at 2:03 PM Maxime Coquelin wrote: > > This patch marks the vDPA driver APIs as internal and > rename the corresponding header file. > > Signed-off-by: Maxime Coquelin > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +- > lib/vhost/meson.build | 4 +++- > lib/vhost/vdpa.c | 2 +- > lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} | 6 ++++++ It is more explicit it is a driver-only header if we rename as vdpa_driver.h or vdpa_pmd.h. [snip] > @@ -86,3 +82,12 @@ EXPERIMENTAL { > rte_vhost_async_channel_unregister_thread_unsafe; > rte_vhost_clear_queue_thread_unsafe; > }; > + > +INTERNAL { > + global; > + > + rte_vdpa_register_device; > + rte_vdpa_unregister_device; > + rte_vhost_host_notifier_ctrl; > + rte_vdpa_relay_vring_used; > +}; Alphabetical order, please. Please also add a note in the release notes. Strictly speaking, this is an announced API change. Cc: techboard. The rest lgtm. Thanks. -- David Marchand