From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E20A4611A; Fri, 24 Jan 2025 09:43:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 193B340E11; Fri, 24 Jan 2025 09:43:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 12D1C40EA5 for <dev@dpdk.org>; Fri, 24 Jan 2025 09:43:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737708199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oiItUAlrOTX12zbwk+ODo6uC4UxBg+B/M/Lr0vTBDQ=; b=G8viagFgEfQx5CFHrLTFfWeViDA6aGBbjLAvw9JRy5/I9spFgLVZxyQ5n1q8mj7V01xj94 14WVfZ1k1IXzTXRrLXNSYIqTsNLOY9eN7Ds2YEsUngrn0FMG/zOrzfEAYPovu8qAjrjm5B OC1lchZg7JYKym/mYLWenDsu1CDA/Kg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-4jthSffMOzqaOkwdJe4JDg-1; Fri, 24 Jan 2025 03:43:17 -0500 X-MC-Unique: 4jthSffMOzqaOkwdJe4JDg-1 X-Mimecast-MFC-AGG-ID: 4jthSffMOzqaOkwdJe4JDg Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-30220c5ca63so12044681fa.3 for <dev@dpdk.org>; Fri, 24 Jan 2025 00:43:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737708196; x=1738312996; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6oiItUAlrOTX12zbwk+ODo6uC4UxBg+B/M/Lr0vTBDQ=; b=BpurvAKjjI9nePKovsqQVSScvSj2TcKEypQK58VbbYcV3mP9I4YKfmm6iQ6Rt3In/p kn+4gBzZVYOmm9vtIshiE99iW3oH7zQFsqPoKvNUaQJp77o1RCF0/Mi2zCmIpgPJBl// aMD4257D0G8soWfd5OYiWL5Y8Hz0A5SvCM2kNqVX/BNxmEWmxNpNwbOZpCvh36LMT5iA 8732hdZ5bHlYyBjrun501m7hRswIp/wx0gps7AoTRqeY3k0KMGMQ3iI1klabmxDbKeBV bwhhZPI1l2W6qw8hbzfqEMRk8LWipmb/8YJOLU+iaxGwPjv5DZV8ogAR4VOr32cSWIkb XmsQ== X-Gm-Message-State: AOJu0Yw4rNHdqWQNLIon37yD93kttB4O4+tFXuPT2hdwKhioOpO/yQKN WBB30PQH1OiTfcPVR0H98t8qV/9FvQU3jrQaIxDKZZYLLAoWrU2j/zM32HQh6mMyt/Fv9K7z4uR tKA0wdTmVyeR7pEJ8GizPUKOfE5cM/E1R2qiXMZaDD+EBMyuIEZh9D2qGRRTKcSy/WQVKRwzDQb bonSwJYkHpid5RMh8= X-Gm-Gg: ASbGncsmCNvcjr93aK7oivBr1R4zKdP3r8VcUL0+dY52CZEXgou6aCc0WjXLjmF3+GS vGeBiHbqMH/t2CoRPiB7zeCX74RlYztADum73atwNt/Lg4VO1X6UKKA== X-Received: by 2002:a2e:be1a:0:b0:302:189f:ea58 with SMTP id 38308e7fff4ca-3072cb13467mr101546901fa.27.1737708195719; Fri, 24 Jan 2025 00:43:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCzr+GS3gyYuSoKFCgr9Dw54JALWVGM0dmSpz3pz+niR9rW0toWDz/vhG6iCIB6vFD6YuWtQrwxOfeW/FHb/M= X-Received: by 2002:a2e:be1a:0:b0:302:189f:ea58 with SMTP id 38308e7fff4ca-3072cb13467mr101546691fa.27.1737708195265; Fri, 24 Jan 2025 00:43:15 -0800 (PST) MIME-Version: 1.0 References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-1-bruce.richardson@intel.com> In-Reply-To: <20250120120016.1530274-1-bruce.richardson@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 24 Jan 2025 09:43:03 +0100 X-Gm-Features: AWEUYZn6do2cXHkjIBGXBZyAwhFvDgamkkvLPiliGY9-9B9FYLjsFNli05FQPUU Message-ID: <CAJFAV8z5HqZv7iS1wOfrJMoq2hoJU4hcnCPX1xhrwGAhEYGGtg@mail.gmail.com> Subject: Re: [PATCH v5 00/25] Reduce code duplication across Intel NIC drivers To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7b7ntLUZCnJ_QZyVs0w0lhCDS6huE_UTcuOyZKeqpEQ_1737708196 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Jan 20, 2025 at 1:00=E2=80=AFPM Bruce Richardson <bruce.richardson@intel.com> wrote: > > This patchset attempts to reduce the amount of code duplication across a > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > As part of this process of deduplication, and in preparation for further > cleanup work, it moves all existing Intel drivers to a net/intel > directory, with a "common" subdirectory being created there for the code > shared between drivers. > > The first deduplication patch extracts a function from the Rx side, > otherwise the majority of the changes are on the Tx side, leading to a > converged Tx queue structure across the 4 drivers, and a large number of > common functions. 394 files changed, 1495 insertions(+), 2510 deletions(-) I like this kind of series the most. I did not enter into the (ugly?) details, but overall it seems good. Thanks for working on this Bruce. --=20 David Marchand