From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45ACFA0C41; Thu, 15 Jul 2021 14:55:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD1F44014D; Thu, 15 Jul 2021 14:55:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6EEC540143 for ; Thu, 15 Jul 2021 14:55:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626353735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8bZmEGSTcNdvKNvEBy2ySHFpTj0HOncZf0ldty4a2ew=; b=ajj0gyarT6s5Zg6B2oJDbwR96NnG3DiiAs5421uhDYlwRZj6mBcGX/J64x5EsNsW/OX5hz uGE1sauC8Ykb6J1p5GphBUirGb5bQhRTrGFTWwddppG/L96lYQnc3x1ePop9mQa20Xq4QN RwF7nSGJRl25I6PE0bSkCo18USDJKrc= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-bLeoqajaMuu2KJuNjHVXEQ-1; Thu, 15 Jul 2021 08:55:34 -0400 X-MC-Unique: bLeoqajaMuu2KJuNjHVXEQ-1 Received: by mail-vk1-f197.google.com with SMTP id c7-20020a1fcc070000b029025824d25004so1450150vkg.17 for ; Thu, 15 Jul 2021 05:55:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8bZmEGSTcNdvKNvEBy2ySHFpTj0HOncZf0ldty4a2ew=; b=jUnq1RCWoz9sGl21KVof0VOpAo0cWDhnB7daeKCsFV4BvbgNii+KYUFWhlgCw2XFEE o1LhIOIkBbF+Dg4VxZDSPrJBE4JNVJ60t8J15BoxgRwL2QNKcMXFzJxNXCgG8XwI6eWa DlUdj5S7QqkXZ4iA3knsAVGgWBhRASgw/z2ihR0sTCfPWkgGr1ISKUaa5PNT/523OO2S m5Ot/9ULz4ktvyJCaYHW/NOsTsA2tl5Z/8mk0ZSeyeZmDWwckdEIBVIfm+puZMAGsG/U obHnce+A6WWR1J0wiQqdtBBRU9WzEwIAZmCzk7731MoL3Ij/Jq3ODtq4T/bMXHzUrAB6 cRuA== X-Gm-Message-State: AOAM532SD4uLqB5CjhZPz6xMOryVVnLTkNW42cGnuvs5n1hQbRkq7cHn 35Y/8RuBHZudfIj21NXLFvK0H5dvfFZnkTtW/0B45wcfIla+Euf4sqOOKRG8tlroFOqjVjTltQ6 XPH/TJ/jcrvTJFlVznMo= X-Received: by 2002:ab0:7e94:: with SMTP id j20mr6735311uax.87.1626353733599; Thu, 15 Jul 2021 05:55:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXS31GCW5l/Mmx/onJxEYSUaxgl+AHKiLnS4G80qBm2DKkZdHw4HGWLNROGR7vlJqYBwF6VnWCWTWiLki19XM= X-Received: by 2002:ab0:7e94:: with SMTP id j20mr6735285uax.87.1626353733365; Thu, 15 Jul 2021 05:55:33 -0700 (PDT) MIME-Version: 1.0 References: <20210707105628.16705-1-ivan.malov@oktetlabs.ru> <20210707105628.16705-2-ivan.malov@oktetlabs.ru> In-Reply-To: <20210707105628.16705-2-ivan.malov@oktetlabs.ru> From: David Marchand Date: Thu, 15 Jul 2021 14:55:22 +0200 Message-ID: To: Ivan Malov Cc: dev , Andrew Rybchenko , Andy Moreton , "Yigit, Ferruh" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] net/sfc: improve logging in MAE backend of RTE flow support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 7, 2021 at 12:56 PM Ivan Malov wrote: > diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h > index bd3b374d68..5b1f34aa7a 100644 > --- a/drivers/net/sfc/sfc_flow.h > +++ b/drivers/net/sfc/sfc_flow.h > @@ -136,13 +136,21 @@ typedef int (sfc_flow_item_parse)(const struct rte_flow_item *item, > > struct sfc_flow_item { > enum rte_flow_item_type type; /* Type of item */ > + const char *name; /* Item name */ > enum sfc_flow_item_layers layer; /* Layer of item */ > enum sfc_flow_item_layers prev_layer; /* Previous layer of item */ > enum sfc_flow_parse_ctx_type ctx_type; /* Parse context type */ > sfc_flow_item_parse *parse; /* Parsing function */ > }; > > -int sfc_flow_parse_pattern(const struct sfc_flow_item *flow_items, > +#define SFC_FLOW_ITEM(_name) \ > + .type = RTE_FLOW_ITEM_TYPE_##_name, \ > + .name = #_name Using this concatenation (same for SFC_FLOW_ACTION) confuses devtools/parse-flow-support.sh script. $ ./devtools/check-doc-vs-code.sh rte_flow doc out of sync for sfc item item pf item phy_port item port_id item pppoes item tcp item vf action Either net/sfc keeps full RTE_FLOW_x_TYPE_y form like other drivers, or the check script must be updated (see exclude/include helpers). -- David Marchand