From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove blank lines in log
Date: Wed, 15 Sep 2021 16:45:52 +0200 [thread overview]
Message-ID: <CAJFAV8z6gk7k+rkvrrvsp+GMtUZZ1vfNdae5q51J40SE3mxjtw@mail.gmail.com> (raw)
In-Reply-To: <20210915141511.2993665-1-thomas@monjalon.net>
On Wed, Sep 15, 2021 at 4:15 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The macro PMD_INIT_LOG includes already the line feed character.
> Redundant \n are removed.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Ah.. I did a similar patch cleaning logs in net/virtio this morning.
Applying and diffing with mine, the differences are:
- calls to PMD_DRV_LOG with the same issue,
- calls to RTE_LOG(xx, PMD, ) (maybe worth a separate patch with a
Fixes: + backport),
This could be done in a followup, or directly as a v2 of this cleanup.
In any case, the current patch lgtm.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2021-09-15 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:15 Thomas Monjalon
2021-09-15 14:45 ` David Marchand [this message]
2021-09-16 1:32 ` Xia, Chenbo
2021-09-16 9:53 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-09-16 14:22 ` David Marchand
2021-09-28 15:35 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z6gk7k+rkvrrvsp+GMtUZZ1vfNdae5q51J40SE3mxjtw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).