From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 388B4A0C41; Wed, 15 Sep 2021 16:46:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 219294068F; Wed, 15 Sep 2021 16:46:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A12C54014F for ; Wed, 15 Sep 2021 16:46:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631717166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ZZEO7huSPgVFKzTcvfe8iZjzfMIbKHgABWGll78bQU=; b=Xd8fJs2XrVf9jNzqKNmNEOGDdTvFk6t1Pt4oISnHzak+OCG32Q/KRtje/8vHh/x8ZqTKPw hQDtWW6SyEI8G8jpUXCLnqwyYX+Bxycm9dsfXEiquBa3qO3G11mXCIGOkv/Bkm/7qqd4rU F0upBJb/7PqHuMU7k0FyqvSNfrVaeqA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-205-gsuis1K6OpuNuAVjctewTA-1; Wed, 15 Sep 2021 10:46:05 -0400 X-MC-Unique: gsuis1K6OpuNuAVjctewTA-1 Received: by mail-lf1-f70.google.com with SMTP id x29-20020ac259dd000000b003f950c726e1so617205lfn.14 for ; Wed, 15 Sep 2021 07:46:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ZZEO7huSPgVFKzTcvfe8iZjzfMIbKHgABWGll78bQU=; b=kWF/SIDfK5l3P54ErKgnHfxbSkp5dvS9pbLTrfAVm/m5YPOQSxvAdlNJiv4EpwT1rD hpQEcvimCxOBkjKHhVApaloNSW80p3ZdHXnvrBalUhuYY5mELTkuYJ3aVTF7O17nazKs /QaF2R7abliQ6uS8yLV5rStsWcifcUKwg2U7OqQWcnI2kUbTRp7NvM+IMqKBPwYknrh3 nEPP3vdQiZTgUXc8VGpYifCZsojigiWkb6RNE08aEhTbqI5YqUEeApjL/iYfOLRdHIlV q6cauWf0xYh2CWaBVClaSpfW+CuIWc2Ep9Ts35mUQSXDG0pYBASuRXC/1AAnMP3nKppu 16Vg== X-Gm-Message-State: AOAM530qmNc2I0pTcZs9+ddIdFYq9lSAzhwcxxuyt7OQsAtdc3SP6Sno GbV2Bqxz2ORKx+AiisJOqnD+XrtiL5+7BMSDcqBkkUVo27tzyXx765uT672vusCfatr5l23H0tH gbzpVIg3+jqdVTR8RbA8= X-Received: by 2002:a2e:131a:: with SMTP id 26mr289731ljt.46.1631717163840; Wed, 15 Sep 2021 07:46:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/kRoUT6qJ/9VaRV0amS5FuH/4pZPmkjoLMcw83WeXBwBeyGRMaX3/baEWmI6nVrLyWlHLRLc53UJhhw/SCgM= X-Received: by 2002:a2e:131a:: with SMTP id 26mr289714ljt.46.1631717163613; Wed, 15 Sep 2021 07:46:03 -0700 (PDT) MIME-Version: 1.0 References: <20210915141511.2993665-1-thomas@monjalon.net> In-Reply-To: <20210915141511.2993665-1-thomas@monjalon.net> From: David Marchand Date: Wed, 15 Sep 2021 16:45:52 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Maxime Coquelin , Chenbo Xia Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove blank lines in log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 4:15 PM Thomas Monjalon wrote: > > The macro PMD_INIT_LOG includes already the line feed character. > Redundant \n are removed. > > Signed-off-by: Thomas Monjalon Ah.. I did a similar patch cleaning logs in net/virtio this morning. Applying and diffing with mine, the differences are: - calls to PMD_DRV_LOG with the same issue, - calls to RTE_LOG(xx, PMD, ) (maybe worth a separate patch with a Fixes: + backport), This could be done in a followup, or directly as a v2 of this cleanup. In any case, the current patch lgtm. Reviewed-by: David Marchand -- David Marchand