From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Gaëtan Rivet" <grive@u256.net>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols
Date: Thu, 7 May 2020 14:43:58 +0200 [thread overview]
Message-ID: <CAJFAV8z6isPKO=fgpqF2do1BYjOR0gP8MQcGOAhRQ+3p1XGdjQ@mail.gmail.com> (raw)
In-Reply-To: <20200506132537.608e73d3@hermes.lan>
On Wed, May 6, 2020 at 10:25 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> > If that is correct, we should use pci_* prefix for static symbols,
> > rte_* for everything else, even "internal" symbols -- in the sense
> > that they are meant to be opaque to the user, but will still be linked
> > in static build.
> >
> > If I'm wrong in thinking this, then ok with this policy and let's go
> > forward to align naming in PCI bus.
> >
>
> Agree that all symbols need a prefix.
> Any symbol that is not static is visible to the application if static linking.
> There is some pre-linking magic can be done but DPDK isn't doing it.
Like automatically prefixing symbols?
--
David Marchand
next prev parent reply other threads:[~2020-05-07 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 12:43 [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function David Marchand
2020-05-06 12:43 ` [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols David Marchand
2020-05-06 17:21 ` Gaëtan Rivet
2020-05-06 20:25 ` Stephen Hemminger
2020-05-07 12:43 ` David Marchand [this message]
2020-05-07 12:41 ` David Marchand
2020-05-06 14:05 ` [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function Gaëtan Rivet
2020-05-11 14:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z6isPKO=fgpqF2do1BYjOR0gP8MQcGOAhRQ+3p1XGdjQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).