From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1D9EA00C5; Thu, 7 May 2020 14:44:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C63771DC77; Thu, 7 May 2020 14:44:14 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 986DB1DC6E for ; Thu, 7 May 2020 14:44:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588855452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xafnhhNTBDO2VMwJVVOsyQ+AEdfBBBO2x6VhZBgFD/U=; b=Ql7WjVyPTc9y8ZFPQPHEvqACD/QFj3Dpz8t/UZBEJBc+dx9GoLG49GZ7ZWKdWOzE9fXS+B yk7aksniLjx/SPuHfIYbvN8x4TGWmYfFxBZ/qxZwHVGNTFrXuflLnkgLY5kDPI0wjdZ7so vEccrvJroa0LPhVoou4baKZ44Hk6VQU= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-mmQF1NNqPJyNufhKnN5Kqw-1; Thu, 07 May 2020 08:44:10 -0400 X-MC-Unique: mmQF1NNqPJyNufhKnN5Kqw-1 Received: by mail-ua1-f72.google.com with SMTP id u10so2345144uad.8 for ; Thu, 07 May 2020 05:44:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4P1EetKiy4Mlv/g2CJCZTJljKHBC8dPhZp3DFu93Zxo=; b=J8mMhim0pw/1ZKxooCqfadQZR7ghRlFe7NedJ83XN8TepZUrHmUH4uLcYwD5cAd6p1 I8ZWg3uY/pD5Zh1C4rI9+35UQWwMxCFlCHSTktY+LA3y/qdBXk/2Opik03F64bbup9I/ HqIOaHOJ2NFXRuOCFI3Jl76ko+oYkBr8mBbWHl/fatdIqNQUpVoffz5RII6g4U06C6lF N6whGrHlI0RJdNONq31tKvZ0K4t+FuJ3hKOOjP11ouceOs4zgkGesCuBs/QqYC3BUIRI Fi6EOBBVEcFPUUehE9M3GXs59lp22BkBTH/6dFRR7Fl6HSgukLlaIy7Rq0Mxtb0bmRPH 96QQ== X-Gm-Message-State: AGi0PubA+hunmDs6ySZWcYT8iAj1kNAG3pzeAdsVmtiX/J4aB/Gy1bnz Hcsb+S023Is1TJB3bE8SeK0fQpfk9s/adg3eT0sgLAMVCz9od7Nna4eR8PUBMfPP1HA1LRj9CWf 8jiMRhZXduR2MWdPXiqI= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr12740794vsq.141.1588855449584; Thu, 07 May 2020 05:44:09 -0700 (PDT) X-Google-Smtp-Source: APiQypJ6xCRiLi7RAke/NvsROs905tgjOTdfMeVBZSq4a12ZPhGtvnhwtAKELgdl23rNqDr0/pxQ8CofWtsi2izrq/Y= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr12740773vsq.141.1588855449322; Thu, 07 May 2020 05:44:09 -0700 (PDT) MIME-Version: 1.0 References: <20200506124314.14009-1-david.marchand@redhat.com> <20200506124314.14009-2-david.marchand@redhat.com> <20200506172123.w37j737azn7ijdxa@u256.net> <20200506132537.608e73d3@hermes.lan> In-Reply-To: <20200506132537.608e73d3@hermes.lan> From: David Marchand Date: Thu, 7 May 2020 14:43:58 +0200 Message-ID: To: Stephen Hemminger Cc: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 10:25 PM Stephen Hemminger wrote: > > If that is correct, we should use pci_* prefix for static symbols, > > rte_* for everything else, even "internal" symbols -- in the sense > > that they are meant to be opaque to the user, but will still be linked > > in static build. > > > > If I'm wrong in thinking this, then ok with this policy and let's go > > forward to align naming in PCI bus. > > > > Agree that all symbols need a prefix. > Any symbol that is not static is visible to the application if static lin= king. > There is some pre-linking magic can be done but DPDK isn't doing it. Like automatically prefixing symbols? --=20 David Marchand