From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7FEAA034F; Fri, 8 Oct 2021 09:08:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1D6E4067E; Fri, 8 Oct 2021 09:08:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A425E40696 for ; Fri, 8 Oct 2021 09:08:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633676907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v2ig3Aa3xBPKToVBI6XsIEKn49E4QK5a1mrrf8lgE9c=; b=fEYx0NdVyZMm8x+fUrznRLWxDPv06yEr496wXC5eyXAP4HXrgNVNGGJjK7pBVIyxOYkpcj qzLbhYDDObb8p55iytcV6vO3lvBPKj+kJ4T6Pe3ZbpGE6n5UH73S+7ImRhpEgJPEM5AsYi fWl0g2p7rAqQ7iQHBHqW8YQXzAzA3QY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-xbF3lsGONNejxaAUw-fdpQ-1; Fri, 08 Oct 2021 03:08:24 -0400 X-MC-Unique: xbF3lsGONNejxaAUw-fdpQ-1 Received: by mail-lf1-f71.google.com with SMTP id d2-20020a0565123d0200b003fd6a0a5403so2029240lfv.11 for ; Fri, 08 Oct 2021 00:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=v2ig3Aa3xBPKToVBI6XsIEKn49E4QK5a1mrrf8lgE9c=; b=46iiuquNYAa/cMEpxZM+pQYNGCiPTQK3xGePfF8LSEoKERpk8/jXqykljzmCtHrCAe oxbdJYoBjPPLDd2FHD/vlKfd805UAnMkHd5LQh+VkNhODwUjNlnWMldNjv2832T42pHv khVBjrmdKsAhrqRz4ttgxGzGCSbfCeqpv04Bs4whm/7cn86nCCAmKMuR9IjCfiTxML/S IfxMTBhBal6BsZUPOkUVaHoierN0aHeOJs8l1FUEqujqF2m0M20qaMQpqcltwJxbmxhH FKCktROPNYo2vmm9e/f3Z6SvMgihF/0MHPhCiglpM+nXCrNga3++6um0cSf1wgh497H1 QqOQ== X-Gm-Message-State: AOAM531IvvHUxbbN9w4LM7CZawf6+v6Hic+wBTZzH2KDildDFnrhA0/v xQdvHLlyUhxh7ExQPIst9hnJ9UhMfwPoVoiIPQzH7aWlZpWecwJ04SdyHKp8zKiSsRf7gzk3VyJ fDZCC+Res5uMpsl6j454= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr8950522lfu.575.1633676903303; Fri, 08 Oct 2021 00:08:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8lKKdG2jjNI+spPZHMoxYxo9MW43Pa7BRxQBbTmIns7ooqoZkRtg3GcEwAvr5VYQ/Igd3iKroRwzbSPQoLR0= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr8950508lfu.575.1633676903116; Fri, 08 Oct 2021 00:08:23 -0700 (PDT) MIME-Version: 1.0 References: <20210910022402.26620-1-chenbo.xia@intel.com> <20210918022443.12719-1-chenbo.xia@intel.com> In-Reply-To: From: David Marchand Date: Fri, 8 Oct 2021 09:08:11 +0200 Message-ID: To: "Liu, Changpeng" Cc: "Xia, Chenbo" , "Harris, James R" , "dev@dpdk.org" , "ci@dpdk.org" , Aaron Conole , dpdklab , "Zawadzki, Tomasz" , "alexeymar@mellanox.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Fri, Oct 8, 2021 at 8:15 AM Liu, Changpeng wro= te: > > I tried the above DPDK patches, and got the following errors: > > pci.c:115:7: error: call to =E2=80=98rte_pci_read_config=E2=80=99 declare= d with attribute error: Symbol is not public ABI > 115 | rc =3D rte_pci_read_config(dev->dev_handle, value, len, offset); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > pci.c: In function =E2=80=98cfg_write_rte=E2=80=99: > pci.c:125:7: error: call to =E2=80=98rte_pci_write_config=E2=80=99 declar= ed with attribute error: Symbol is not public ABI > 125 | rc =3D rte_pci_write_config(dev->dev_handle, value, len, offset)= ; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > pci.c: In function =E2=80=98register_rte_driver=E2=80=99: > pci.c:375:2: error: call to =E2=80=98rte_pci_register=E2=80=99 declared w= ith attribute error: Symbol is not public ABI > 375 | rte_pci_register(&driver->driver); I should have got this warning... but compilation passed fine for me. Happy you tested it. > > We may use the new added API to replace rte_pci_write_config and rte_pci_= read_config, but SPDK > do require rte_pci_register(). Since SPDK has a PCI driver, you'll need to compile code that calls those PCI driver internal API with ALLOW_INTERNAL_API defined. You can probably add a #define ALLOW_INTERNAL_API first thing (it's important to have it defined before including any dpdk header) in pci.c Another option, is to add it to lib/env_dpdk/env.mk:ENV_CFLAGS =3D $(DPDK_INC) -DALLOW_EXPERIMENTAL_API. Can someone from SPDK take over this and sync with Chenbo? Thanks. --=20 David Marchand