From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 833AF43BD6; Wed, 28 Feb 2024 15:44:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 559C240DCD; Wed, 28 Feb 2024 15:44:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C2ABC406B7 for ; Wed, 28 Feb 2024 15:44:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709131443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85qCQvDiLi9boUVCMBtBRgUN8MzQ+06jYLpD/lQwJ5U=; b=cSZq5IznCZeEes9e4MqtAFnDXypeppDzqh78hVysMYDuSspkGVmZxWbGuTgoYIFURhgEAx motCgPd+FcH+0Y3ZA6yRZjloUXalg5GUt4NOzlwZF2s6YpsiVEbGgO50JA0p2cUyQOTKLh LX8i+R2daiohJNDZcg5zfQuYqshoT1g= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-ApO-qT7jMNWHtZe57bEzzw-1; Wed, 28 Feb 2024 09:44:00 -0500 X-MC-Unique: ApO-qT7jMNWHtZe57bEzzw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d27af05d98so41308861fa.1 for ; Wed, 28 Feb 2024 06:44:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709131439; x=1709736239; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=85qCQvDiLi9boUVCMBtBRgUN8MzQ+06jYLpD/lQwJ5U=; b=VymqImw2YgKRXb+cvAJGoNSYpZzhFm3R08gxIHXfrpt1EkCAgFgdpVjIOcy3cYBNUc 6TseTbh41Vx9KxuA5eu58jLDyYLaSpE3kUqbxdZe5lbR5W80OE0/5D+JdC7tKJ6P+MsQ dzjAWZ1ahDfsh998C+uRWGPp1v2js/mxK54AvH6XdLGcTCCTb5XlsuawzZKbVhquSDf/ xtvTHu6PXzd5mwMh4AGS0P4ia70XkK8pIMiTQV3HCupukK8/wwSA74f4Aew8DNMuo1Eb om8a1jj7D7XXx2CTT3RRNXI0xr4VqvNmO9kLDsHMfBkE+aJUFaU54OQ/S2dF01Qnqc3q VsKQ== X-Gm-Message-State: AOJu0YyyLte9vwJYBKqFG3de711qx7V9cwZLQ83z+TiDmZfAjoRERL5i 4zWMW3gEdFOy6cKEjWMh1srpKsMK9OBXKPbQjIXu+A4ufdtPnXFQ3aTU3yxfKtP4GBntaTcpsDW F+R62o00zjz4Drx+g4snxXGWbatcNy3wousGG7f+1B0xsXYMfDhq9Vs4vXP49cAM/ANm69yT8x/ dlVf1eacQwJpOSqmw= X-Received: by 2002:a05:6512:3987:b0:513:202b:9001 with SMTP id j7-20020a056512398700b00513202b9001mr294775lfu.6.1709131439267; Wed, 28 Feb 2024 06:43:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhs/DpE6TDOv7vJ0YMhjKAYJqprIG1tGqwQj5/G8cqeAlfzD++xwIv0autyb+NPu2dZN7k4wJlp6R+AMbVve0= X-Received: by 2002:a05:6512:3987:b0:513:202b:9001 with SMTP id j7-20020a056512398700b00513202b9001mr294759lfu.6.1709131438919; Wed, 28 Feb 2024 06:43:58 -0800 (PST) MIME-Version: 1.0 References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com> <87cysgd6sy.fsf@redhat.com> In-Reply-To: <87cysgd6sy.fsf@redhat.com> From: David Marchand Date: Wed, 28 Feb 2024 15:43:46 +0100 Message-ID: Subject: Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields To: Dodji Seketeli Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com, Tyler Retzlaff , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 3:04=E2=80=AFPM Dodji Seketeli w= rote: > > Btw, I see no way to suppress this (except a global [suppress_type] > > name =3D rte_mbuf)... > > Right. > > To avoid having subsequent changes to that type from being "overly" > suppressed, maybe do something like: > > [suppress_type] > name =3D rte_mbuf > has_size_change =3D no > has_data_member =3D {cacheline0, rearm_data, rx_descriptor_fields1, = cacheline1} > > That way, only size-impacting changes to struct rte_mbuf in its form > that predates this patch would be suppressed, hopefully. Do you mean, only changes *not* size-impacting would be suppressed? This is slightly better than the suppression on the whole rte_mbuf object, but it won't catch field reordering iiuc. On the other hand, now that I try reordering fields (to test this suggestion of yours), I get build failures all over the DPDK tree because we have many build checks to ensure those fields are at known locations... So maybe we can relax and just go with the full suppression. --=20 David Marchand