From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
Parav Pandit <parav@nvidia.com>, Xueming Li <xuemingl@nvidia.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Long Li <longli@microsoft.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v2] drivers/bus: set device NUMA node to unknown by default
Date: Thu, 6 Oct 2022 21:31:55 +0200 [thread overview]
Message-ID: <CAJFAV8z8nq1o5aEkH6e38+hmrQP_Ha4_+y0N6UVtof432z5baw@mail.gmail.com> (raw)
In-Reply-To: <20221004145850.32331-1-olivier.matz@6wind.com>
On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> The dev->device.numa_node field is set by each bus driver for
> every device it manages to indicate on which NUMA node this device lies.
>
> When this information is unknown, the assigned value is not consistent
> across the bus drivers.
>
> Set the default value to SOCKET_ID_ANY (-1) by all bus drivers
> when the NUMA information is unavailable. This change impacts
> rte_eth_dev_socket_id() in the same manner.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> v2
> * use SOCKET_ID_ANY instead of -1 in drivers/dma/idxd (David)
> * document the behavior change of rte_eth_dev_socket_id()
> * fix few examples where rte_eth_dev_socket_id() was expected to
> return 0 on unknown socket
Applied with suggestion on setting rte_errno for rte_eth_dev_socket_id().
Thanks Olivier!
--
David Marchand
prev parent reply other threads:[~2022-10-06 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:05 [PATCH] " Olivier Matz
2022-09-30 7:10 ` David Marchand
2022-09-30 8:11 ` Olivier Matz
2022-10-04 14:58 ` [PATCH v2] " Olivier Matz
2022-10-05 8:52 ` David Marchand
2022-10-05 9:04 ` Olivier Matz
2022-10-05 9:32 ` Thomas Monjalon
2022-10-06 19:31 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z8nq1o5aEkH6e38+hmrQP_Ha4_+y0N6UVtof432z5baw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=hemant.agrawal@nxp.com \
--cc=longli@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=parav@nvidia.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).