From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21879A00C2; Thu, 6 Oct 2022 21:32:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDD22400D6; Thu, 6 Oct 2022 21:32:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7110540042 for ; Thu, 6 Oct 2022 21:32:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665084728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMCzym+H+TEMlH529ZTWJSmopPWl5KzjyaHZV7ve4Yo=; b=iUi/6bzIcWNq0c7pLHjquY3qlXWq7UUQqE5cQgMnWbVZhWVxYuB4bPwWso207oNWn8ZfQO IDzeeC7TgXBvUmuQ1MSru8HiDdDNeteCtXhwZ2MaeHjgr40Thd9OJdqOLlrsNVi/aWaoop ieT4tnNaevsthG7TYQ/bpk47cTDx1Bs= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-314-992m8sIAORSwE2tPmD2cyQ-1; Thu, 06 Oct 2022 15:32:08 -0400 X-MC-Unique: 992m8sIAORSwE2tPmD2cyQ-1 Received: by mail-pg1-f199.google.com with SMTP id f186-20020a636ac3000000b0044adaa7d347so1619237pgc.14 for ; Thu, 06 Oct 2022 12:32:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=pMCzym+H+TEMlH529ZTWJSmopPWl5KzjyaHZV7ve4Yo=; b=g5Qw18FL9PZWK1lwj+7DStwc/b5ljS9PR+/Mv8pFGizx89OFRnauBudonuwfy2/5YR 5tSnH6WzvXtxGELyzzH3aGuvqEr+vU4pJdCpWEfEO7Wj/pusw4dmVj0CQ4wfbwpuRk5E 8JWFtMxUtJSoFRwfuTEMhtrjZw2peD2ds2EQNVyApPniCNgRHL1ew1D24C+UFNEVeF1b xNVIxVAXHAU/R/2tHw4fYr1ef4H7tJhHXdgFjLubSpKuqC0K9BcjzcQFWCKP99Qd4IYu la+BnLU/dqSIXmpxP88cLwx4Z0Ws7bU8R82X8/oVQasDbyCzWTQfBKMaDAltS3Ewnm/c d9pg== X-Gm-Message-State: ACrzQf3H+y55oDIKvzkSqOiLYHHDyDDD06ZqJYFuZZiMUz1Y2Rmx69e7 g7Rg8PJkTF4m6L96k6W4qBpuyP+c1rh3JuMmaJF08EIkkxPk33ctx+0GLzw5vV/ZvV3O3u9G1wT daQKqAGItKd3XmlsD8QU= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr1323328plh.172.1665084726894; Thu, 06 Oct 2022 12:32:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5G8Ot6UIoNJw/l2WrV4ns1OLHUAeID1/pRzqYulGflh8E7FRA/kSo/tBi+1dVod9puc6XEQCwN7FSNRueOmU8= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr1323300plh.172.1665084726648; Thu, 06 Oct 2022 12:32:06 -0700 (PDT) MIME-Version: 1.0 References: <20221004145850.32331-1-olivier.matz@6wind.com> In-Reply-To: <20221004145850.32331-1-olivier.matz@6wind.com> From: David Marchand Date: Thu, 6 Oct 2022 21:31:55 +0200 Message-ID: Subject: Re: [PATCH v2] drivers/bus: set device NUMA node to unknown by default To: Olivier Matz Cc: dev@dpdk.org, Ray Kinsella , Parav Pandit , Xueming Li , Hemant Agrawal , Sachin Saxena , Stephen Hemminger , Long Li , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote: > > The dev->device.numa_node field is set by each bus driver for > every device it manages to indicate on which NUMA node this device lies. > > When this information is unknown, the assigned value is not consistent > across the bus drivers. > > Set the default value to SOCKET_ID_ANY (-1) by all bus drivers > when the NUMA information is unavailable. This change impacts > rte_eth_dev_socket_id() in the same manner. > > Signed-off-by: Olivier Matz > --- > > v2 > * use SOCKET_ID_ANY instead of -1 in drivers/dma/idxd (David) > * document the behavior change of rte_eth_dev_socket_id() > * fix few examples where rte_eth_dev_socket_id() was expected to > return 0 on unknown socket Applied with suggestion on setting rte_errno for rte_eth_dev_socket_id(). Thanks Olivier! -- David Marchand