From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F3CF455F2; Thu, 11 Jul 2024 13:39:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D9CD4065B; Thu, 11 Jul 2024 13:39:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F2E3B4021F for ; Thu, 11 Jul 2024 13:39:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720697980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X6u0enAlgXoiNKj2Ov9TtLlhMwL8FdbamPIa9dhRXog=; b=BCHIyEc8VUlei6E2cp7DR3wNv2FjxoCXLZlrjHWPZXFbUQxNBRyl6tNcUyFzaxRoeT6itI HqPSJskosZa4/Z/wJX+j+zUQaZIa/55V0f6MLbS+ceb4sPoN2AsW/iL4Xms1G8sG5HmBy3 sSZAqiVNxoU+zCcUNZ5UMlbW0UO32gU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-HyDu_u0EPkO1dQNvfW-BIw-1; Thu, 11 Jul 2024 07:39:37 -0400 X-MC-Unique: HyDu_u0EPkO1dQNvfW-BIw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee9b1b2cdcso6553981fa.1 for ; Thu, 11 Jul 2024 04:39:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720697976; x=1721302776; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X6u0enAlgXoiNKj2Ov9TtLlhMwL8FdbamPIa9dhRXog=; b=Y79AfYTSI6z0Unc1hIv7+2hGDIa9XgJnPgqFQpRFnao00TWmtUAYMlTW5S2R4oVQmc OtXUrmKjwnuCVkoSZuvefN7c526MTxgBj/S/iueZp2CKrGvg/WyU6fw3j9Fw0O4SKhvA FcggLRDm7M50Y5h1wiaVdF9lZw7M4KDFpDPGPvLsrAhkvotWMHuhfWto730Wc7wzrAQl jX3SfZ9y3EAPFLBkkZUbN/6J7HPFX7QlAnVAkem3w63v4CzrEpEPHav8UKDcln6FQ8yx kwFxRjzUKbF28ljNudFdRo2PjMP1RyGe5doMOI0hxVWZ7dRdL0fNjSO1VR559UJsUPdX YWlA== X-Gm-Message-State: AOJu0YxXrfcxiZj5T+BNWzURsyndy1YJE8l4BOsCKWeOFdQXgmG6Gmrt q9nkVJ6Q5VXtvG6S4GDTwfbtL9pG2OS0HrsIN51HCLF7TBtkw7DQz1+6ZpNliP4UAe1QuJJ8jUT 6dEmKEtQik6rtD++1/IbqjYd3o2Tmet0srAEiaJiT2ywqWyLPuLHyvJxudK1jyj/jo1K8fvuO42 EVY3Hdgw65pIwhAWI= X-Received: by 2002:a2e:9495:0:b0:2ec:1ce8:9a7d with SMTP id 38308e7fff4ca-2eeb30b83f4mr54528271fa.4.1720697975875; Thu, 11 Jul 2024 04:39:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjFqsJqxuWcgtRxHwikO1kScFhz/FGrHkl3Kn0+UtgU54fsUOzy0pnx2QPw4PVFe2p9Jlk5mTmbvN00HX1fWo= X-Received: by 2002:a2e:9495:0:b0:2ec:1ce8:9a7d with SMTP id 38308e7fff4ca-2eeb30b83f4mr54528141fa.4.1720697975510; Thu, 11 Jul 2024 04:39:35 -0700 (PDT) MIME-Version: 1.0 References: <20240701103315.835249-1-mingjinx.ye@intel.com> <20240705082550.1670765-1-mingjinx.ye@intel.com> In-Reply-To: <20240705082550.1670765-1-mingjinx.ye@intel.com> From: David Marchand Date: Thu, 11 Jul 2024 13:39:23 +0200 Message-ID: Subject: Re: [PATCH v3] buildtools: fix invalid symbols To: Mingjin Ye Cc: dev@dpdk.org, alialnu@nvidia.com, stable@dpdk.org, Dmitry Kozlyuk X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 5, 2024 at 10:49=E2=80=AFAM Mingjin Ye = wrote: > > In scenarios where a higher clang compiler is used and ASAN is enabled, > the generated ELF file will additionally insert undefined debug symbols > with the same prefix. This causes duplicate C code to be generated. > > This patch fixes this issue by skipping the unspecified symbol type. You did not reply to my comments on v3 and here we have a new hack. This hack is ugly and not future proof (I can imagine some other symbols may appear in the future. If those symbols are not of type "STT_NOTYPE" we will have to find another filter at this point...). Please have a try with: https://patchwork.dpdk.org/project/dpdk/patch/20240711113851.975368-1-david= .marchand@redhat.com/ Thanks. --=20 David Marchand