From: David Marchand <david.marchand@redhat.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v3 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri
Date: Wed, 29 Jan 2025 14:56:59 +0100 [thread overview]
Message-ID: <CAJFAV8z9X38j-9Dd0702NgnKcSmynKYDyQmsTS=QwY4G2nfdEQ@mail.gmail.com> (raw)
In-Reply-To: <1737735244-23234-1-git-send-email-andremue@linux.microsoft.com>
On Fri, Jan 24, 2025 at 5:46 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> MSVC does not support inline assembly so use movdiri intrinsic and
> provide abstracted rte_ffs{32,64} inline functions instead of directly
> using GCC built-ins.
>
> v3:
> * Added __rte_experimental to the new functions.
> * Added comments to the new functions.
> * Moved tests to test_bitcount.c
>
> v2:
> * Moved constants to the right side of the comparison
> * Added tests for rte_ffs32 and rte_ffs64 functions
>
> Andre Muezerie (1):
> app/test: add test for rte_ffs32 and rte_ffs64 functions.
>
> Tyler Retzlaff (2):
> eal: provide movdiri for MSVC
> eal: add rte ffs32 and rte ffs64 inline functions
>
> app/test/test_bitcount.c | 38 ++++++++++++++++++
> lib/eal/include/rte_bitops.h | 74 ++++++++++++++++++++++++++++++++++++
> lib/eal/x86/include/rte_io.h | 4 ++
> 3 files changed, 116 insertions(+)
Series applied, thanks Tyler and André.
--
David Marchand
prev parent reply other threads:[~2025-01-29 13:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 21:24 [PATCH 0/2] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri for MSVC Tyler Retzlaff
2024-03-20 21:24 ` [PATCH 1/2] eal: provide movdiri " Tyler Retzlaff
2024-03-20 21:24 ` [PATCH 2/2] eal: add rte ffs32 and rte ffs64 inline functions Tyler Retzlaff
2024-06-14 14:49 ` David Marchand
2024-12-05 20:17 ` Andre Muezerie
2024-12-05 20:35 ` [PATCH v2 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri Andre Muezerie
2024-12-05 20:35 ` [PATCH v2 1/3] eal: provide movdiri for MSVC Andre Muezerie
2024-12-05 20:35 ` [PATCH v2 2/3] eal: add rte ffs32 and rte ffs64 inline functions Andre Muezerie
2024-12-05 20:35 ` [PATCH v2 3/3] app/test: add test for rte_ffs32 and rte_ffs64 functions Andre Muezerie
2025-01-24 14:53 ` [PATCH v2 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri David Marchand
2025-01-24 16:16 ` Andre Muezerie
2025-01-24 16:14 ` [PATCH v3 " Andre Muezerie
2025-01-24 16:14 ` [PATCH v3 1/3] eal: provide movdiri for MSVC Andre Muezerie
2025-01-24 16:14 ` [PATCH v3 2/3] eal: add rte ffs32 and rte ffs64 inline functions Andre Muezerie
2025-01-24 16:14 ` [PATCH v3 3/3] app/test: add test for rte_ffs32 and rte_ffs64 functions Andre Muezerie
2025-01-29 13:56 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z9X38j-9Dd0702NgnKcSmynKYDyQmsTS=QwY4G2nfdEQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).