From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40D514610D; Wed, 29 Jan 2025 14:57:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6B4D402AE; Wed, 29 Jan 2025 14:57:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7577240274 for ; Wed, 29 Jan 2025 14:57:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738159035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0zykVqBrSiOO0kNnyEyv8O6fn3GgJLDB8vrOFLHqv3U=; b=eqFViiq6TFttcnkAsyrFyXKeSCJ3umz4oKbpJyNinY+mFJRVRo0bYYIVqTvDPFZDrKcTcJ gsskXI/doeveFjORV3MfkGQ1vrL7EQ7fp38b+Epdq3shPqro8CUw5SR/6UbJs7HhUysVd+ 86Gbp6+OCzJW5YjXtoJ0T1+IcQRoC2A= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-0Ydd3mslM1yYS6rcvrRCxw-1; Wed, 29 Jan 2025 08:57:13 -0500 X-MC-Unique: 0Ydd3mslM1yYS6rcvrRCxw-1 X-Mimecast-MFC-AGG-ID: 0Ydd3mslM1yYS6rcvrRCxw Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5424a89c885so3201779e87.0 for ; Wed, 29 Jan 2025 05:57:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738159032; x=1738763832; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0zykVqBrSiOO0kNnyEyv8O6fn3GgJLDB8vrOFLHqv3U=; b=KOXHHOznjPcupuLri4ApVXvMpRjSHZYjaK0/fu5dqKv1uwqHHMXbygF3sBiuQjSRIl FNCjOFoFzxDqS+vUWEVlzWW66aX/E3ctmyqiGSxVXeDfuRjlwIXC680RWflhcCCwXR2r O1t0EhC1VgwEqhxT+scwl8Zael2+Q6f0pG1ijDOmTqcrHQfU55cv1h4z2s/O6vCSpor0 WR64qpFpiKwSNOWHtPJVsKXuOHYAhiv6hYjx3sUBbXU/hTfrWPxfKsha8P+THFL7+q87 axwL1ZD2CIGWbQGq6yUbcZH60GKxDSmlOKYIKx5VxTEvUBbMhOCazOhilUyXQiAPDSOX ++Pg== X-Gm-Message-State: AOJu0YyaPzG5iK/MPD/6s5AEdY4eWWuORWhiy1ZkRBp2TQsMUyUSWmDV +XadH1+ALfmsDOFTkvWTyN+Y00RqFE7OB3EgVND5EDDFB9A5eHLUnfxduRvfs8FLhPtAmiRFzlH JJXHxeDCqNFiTIOKha5eu3OS/spUjnWfRaXyDUjtpSELa5wKA+1dIfKqZEULebbp5FBr2BSYi5V IVsj69XzCXPyESvYo= X-Gm-Gg: ASbGncsB+YLHYkEkA5TJYKDIzGlrx0tIta03/z+LWMCRXM/EwlaDiQMZFvI6S1hZfB8 8BlgYfZg1dD/Qy7JyUS36TKNInKC7278OMdpBdJcb7bP7M2d3rXy5wziYGHtdl6RC X-Received: by 2002:a05:6512:3f02:b0:540:353a:5b1f with SMTP id 2adb3069b0e04-543e4ba55a0mr1102197e87.0.1738159031847; Wed, 29 Jan 2025 05:57:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEmAsdxVZHprtsysTWxZCxgIh9mf2Vx8By6CH8P7o2Wn/eZnBXoI1PGpR+Sq/w1wNQxN2dMHs5r7LJwVEd6+s= X-Received: by 2002:a05:6512:3f02:b0:540:353a:5b1f with SMTP id 2adb3069b0e04-543e4ba55a0mr1102187e87.0.1738159031470; Wed, 29 Jan 2025 05:57:11 -0800 (PST) MIME-Version: 1.0 References: <1710969879-23701-1-git-send-email-roretzla@linux.microsoft.com> <1737735244-23234-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1737735244-23234-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 29 Jan 2025 14:56:59 +0100 X-Gm-Features: AWEUYZn_yW7DkwoOzD8FjQl79pQ36fSC2CqmG598KNpxX0Ad0MMfVn8iZDFVQeA Message-ID: Subject: Re: [PATCH v3 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri To: Andre Muezerie Cc: dev@dpdk.org, Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zwrWbHwEOeSxjKSAvC8Il-FamKOIE_N21QkJAA5j4ms_1738159032 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 24, 2025 at 5:46=E2=80=AFPM Andre Muezerie wrote: > > MSVC does not support inline assembly so use movdiri intrinsic and > provide abstracted rte_ffs{32,64} inline functions instead of directly > using GCC built-ins. > > v3: > * Added __rte_experimental to the new functions. > * Added comments to the new functions. > * Moved tests to test_bitcount.c > > v2: > * Moved constants to the right side of the comparison > * Added tests for rte_ffs32 and rte_ffs64 functions > > Andre Muezerie (1): > app/test: add test for rte_ffs32 and rte_ffs64 functions. > > Tyler Retzlaff (2): > eal: provide movdiri for MSVC > eal: add rte ffs32 and rte ffs64 inline functions > > app/test/test_bitcount.c | 38 ++++++++++++++++++ > lib/eal/include/rte_bitops.h | 74 ++++++++++++++++++++++++++++++++++++ > lib/eal/x86/include/rte_io.h | 4 ++ > 3 files changed, 116 insertions(+) Series applied, thanks Tyler and Andr=C3=A9. --=20 David Marchand