* Re: [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage
2020-11-02 11:38 [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage Ibtisam Tariq
@ 2020-11-05 8:56 ` David Marchand
2020-11-09 9:11 ` Maxime Coquelin
2020-11-09 16:32 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-11-05 8:56 UTC (permalink / raw)
To: Ibtisam Tariq; +Cc: Maxime Coquelin, Xia, Chenbo, dev, Fan Zhang
On Mon, Nov 2, 2020 at 12:56 PM Ibtisam Tariq <ibtisam.tariq@emumba.com> wrote:
>
> Add new line character(\n) in the usage of vhost_crypto example for
> better readability
>
> Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 11ad49159..29c8f7228 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -195,7 +195,7 @@ vhost_crypto_usage(const char *prgname)
> {
> printf("%s [EAL options] --\n"
> " --%s <lcore>,SOCKET-FILE-PATH\n"
> - " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]"
> + " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\n"
> " --%s: zero copy\n"
> " --%s: guest polling\n",
> prgname, SOCKET_FILE_KEYWORD, CONFIG_KEYWORD,
> --
> 2.17.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage
2020-11-02 11:38 [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage Ibtisam Tariq
2020-11-05 8:56 ` David Marchand
@ 2020-11-09 9:11 ` Maxime Coquelin
2020-11-09 16:32 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-11-09 9:11 UTC (permalink / raw)
To: Ibtisam Tariq, chenbo.xia; +Cc: dev, roy.fan.zhang
On 11/2/20 12:38 PM, Ibtisam Tariq wrote:
> Add new line character(\n) in the usage of vhost_crypto example for
> better readability
>
> Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 11ad49159..29c8f7228 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -195,7 +195,7 @@ vhost_crypto_usage(const char *prgname)
> {
> printf("%s [EAL options] --\n"
> " --%s <lcore>,SOCKET-FILE-PATH\n"
> - " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]"
> + " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\n"
> " --%s: zero copy\n"
> " --%s: guest polling\n",
> prgname, SOCKET_FILE_KEYWORD, CONFIG_KEYWORD,
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage
2020-11-02 11:38 [dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage Ibtisam Tariq
2020-11-05 8:56 ` David Marchand
2020-11-09 9:11 ` Maxime Coquelin
@ 2020-11-09 16:32 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-11-09 16:32 UTC (permalink / raw)
To: Ibtisam Tariq, chenbo.xia; +Cc: dev, roy.fan.zhang
On 11/2/20 12:38 PM, Ibtisam Tariq wrote:
> Add new line character(\n) in the usage of vhost_crypto example for
> better readability
>
> Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 11ad49159..29c8f7228 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -195,7 +195,7 @@ vhost_crypto_usage(const char *prgname)
> {
> printf("%s [EAL options] --\n"
> " --%s <lcore>,SOCKET-FILE-PATH\n"
> - " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]"
> + " --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\n"
> " --%s: zero copy\n"
> " --%s: guest polling\n",
> prgname, SOCKET_FILE_KEYWORD, CONFIG_KEYWORD,
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread