From: David Marchand <david.marchand@redhat.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev <dev@dpdk.org>, Zhihong Peng <zhihongx.peng@intel.com>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] pmdinfogen: allow padding after NUL terminator
Date: Thu, 27 May 2021 08:53:19 +0200 [thread overview]
Message-ID: <CAJFAV8z9jOr9YWMaEbhYrcC2gbw2mTA67kQXuS3zB4Dg+UY6=A@mail.gmail.com> (raw)
In-Reply-To: <20210526214343.31352-1-dmitry.kozliuk@gmail.com>
On Wed, May 26, 2021 at 11:44 PM Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com> wrote:
>
> Size of string constant symbol may be larger than its length
> measured up to NUL terminator. In this case pmdinfogen included padding
> bytes after NUL terminator in generated source, yielding incorrect code.
>
> Always trim string data to NUL terminator while reading ELF.
> It was already done for COFF because there's no symbol size.
>
> Bugzilla ID: 720
> Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen")
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Reproduced the issue described in bz on my (old) RHEL7 with clang 3.4.2.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Just to confirm my reading of the C version of pmdinfogen: the C
version formats those symbols fine with printf %s.
So there should be no need for a fix in stable branches, right?
--
David Marchand
next prev parent reply other threads:[~2021-05-27 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 21:43 Dmitry Kozlyuk
2021-05-27 6:53 ` David Marchand [this message]
2021-05-27 7:09 ` Dmitry Kozlyuk
2021-05-27 7:31 ` David Marchand
2021-05-27 21:24 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-06-09 15:52 ` Dmitry Kozlyuk
2021-06-09 16:01 ` [dpdk-dev] [dpdk-ci] " Lincoln Lavoie
2021-06-09 16:48 ` Dmitry Kozlyuk
2021-06-09 17:19 ` Owen Hilyard
2021-06-18 14:39 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z9jOr9YWMaEbhYrcC2gbw2mTA67kQXuS3zB4Dg+UY6=A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).