* [dpdk-dev] [PATCH] config: fix kni build
@ 2020-10-20 9:17 Bruce Richardson
2020-10-20 10:03 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-10-20 9:17 UTC (permalink / raw)
To: dev; +Cc: david.marchand, Bruce Richardson
When building kernel modules such as kni, the "config" directory is not
passed as a standard path in the EXTRA_CFLAGS value, meaning that the
rte_compatibility_defines.h is not found from rte_config.h. However, since
both headers are in the same directory, we can just use quotes rather than
angle-brackets to ensure the second header is always found if the first is.
Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/rte_config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/rte_config.h b/config/rte_config.h
index f64b4d634..8aa46a1aa 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -13,7 +13,7 @@
#define _RTE_CONFIG_H_
#include <rte_build_config.h>
-#include <rte_compatibility_defines.h>
+#include "rte_compatibility_defines.h"
/* legacy defines */
#ifdef RTE_EXEC_ENV_LINUX
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] config: fix kni build
2020-10-20 9:17 [dpdk-dev] [PATCH] config: fix kni build Bruce Richardson
@ 2020-10-20 10:03 ` David Marchand
2020-10-20 10:31 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-10-20 10:03 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When building kernel modules such as kni, the "config" directory is not
> passed as a standard path in the EXTRA_CFLAGS value, meaning that the
> rte_compatibility_defines.h is not found from rte_config.h. However, since
> both headers are in the same directory, we can just use quotes rather than
> angle-brackets to ensure the second header is always found if the first is.
>
> Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] config: fix kni build
2020-10-20 10:03 ` David Marchand
@ 2020-10-20 10:31 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-10-20 10:31 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Tue, Oct 20, 2020 at 12:03 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When building kernel modules such as kni, the "config" directory is not
> > passed as a standard path in the EXTRA_CFLAGS value, meaning that the
> > rte_compatibility_defines.h is not found from rte_config.h. However, since
> > both headers are in the same directory, we can just use quotes rather than
> > angle-brackets to ensure the second header is always found if the first is.
> >
> > Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 9:17 [dpdk-dev] [PATCH] config: fix kni build Bruce Richardson
2020-10-20 10:03 ` David Marchand
2020-10-20 10:31 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).