From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B949C41BBB; Fri, 3 Feb 2023 10:14:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 941024021E; Fri, 3 Feb 2023 10:14:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 57FDF4014F for ; Fri, 3 Feb 2023 10:14:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675415680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQyMoop4uerS2ERZEzvM9x7BQQcJ/3B1+vgee62mygo=; b=EITXp5mafdswWsrlAdQjhxYVzP3Knuq4c/g+scjRxw3OjxKFNTSoJMjhL0j84DCnt/ttEj Ey6QFwpqDaan7SPPA/DLtO3QtCmFoMX+Xhi56ZQu1hc6YZf3BG9StPY1ea/8eQ99c8f5z3 OuoEFjEzGPJsRVRFxcy5Pzll6Nbxwxw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-544-KdMZf0YbMf6t6lv1VrTEow-1; Fri, 03 Feb 2023 04:14:39 -0500 X-MC-Unique: KdMZf0YbMf6t6lv1VrTEow-1 Received: by mail-pj1-f70.google.com with SMTP id y23-20020a17090aca9700b0022beb2b98a9so2153301pjt.2 for ; Fri, 03 Feb 2023 01:14:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vQyMoop4uerS2ERZEzvM9x7BQQcJ/3B1+vgee62mygo=; b=UTa6HzauL0/vAw3KEGKJWhddBaVIyJeC+Fo7qYML0T8e3m9WXjAoSl8FRLZzrhAPOo K5dxa06yFo5qzkFbMk6Gxt40cMWy1AA3LrVNr/aPssjGBKcVcAXepFXlrkascIqbi795 ddhuarFLu9ZwTSNwPKdhvNBben4o1e7XmAmymkicmQwjQwl5TUE8yt7TPC6jVtOKeKDq xwGThMMittAh1niGTM7QFLDVfwPyMuZwUI4pItdCQz6UPCX10/yVqY1LO5zcqUBjDSzE 3+xX1fcFaSWq9/RlmZBAConUTfAjYnVt79pYnBZIVPby4NRgDGHSpgzDmepr55weXWd2 BVvw== X-Gm-Message-State: AO0yUKUO0Q9eRJKAsH6CORDW+1DKYhg9Q+w+NNonuk9v9j8vpnzQS0Tw mFCf7Im5ohCNjxAaMwvvzaFXzkZuA5+oaX0bWOU5e9lULoqf713f1Tw5DqcUnq8uX7MzdGKBUPV aWSkKJFNRUXnodW7ug8g= X-Received: by 2002:a05:6a00:1a8d:b0:590:6fcc:be6f with SMTP id e13-20020a056a001a8d00b005906fccbe6fmr2153742pfv.49.1675415678445; Fri, 03 Feb 2023 01:14:38 -0800 (PST) X-Google-Smtp-Source: AK7set8+pwekAVwhvsiYkcNJOdbXG6dt9Sns7+MOBOL9b+bbaVRQ1YYh7h2pbIVVCqySmAe//YLGtIK69h6tBd8B3ZE= X-Received: by 2002:a05:6a00:1a8d:b0:590:6fcc:be6f with SMTP id e13-20020a056a001a8d00b005906fccbe6fmr2153739pfv.49.1675415678138; Fri, 03 Feb 2023 01:14:38 -0800 (PST) MIME-Version: 1.0 References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com> <20230120221418.GA9231@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230202155733.GB20115@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230202155733.GB20115@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Fri, 3 Feb 2023 10:14:26 +0100 Message-ID: Subject: Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction To: Tyler Retzlaff , thomas@monjalon.net Cc: dev@dpdk.org, mb@smartsharesystems.com, bruce.richardson@intel.com, ferruh.yigit@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 2, 2023 at 4:57 PM Tyler Retzlaff wrote: > > > I like the cleanup of rte_common.h and additional unit tests, but the > > > MSVC bits don't belong here. > > > Please move them in your MSVC enablement series > > > https://patchwork.dpdk.org/project/dpdk/list/?series=26662&state=%2A&archive=both. > > > > Addendum, running the series through my checks, I can see that > > test_bitcount.c is left unattended wrt the MAINTAINERS file. > > app/test/test_bitcount.c must be put under the "EAL API and common > > code" section. > > is this an automated check i should have run prior to submission? The script is devtools/check-maintainers.sh. But unfortunately it is not run in the CI as its author never made it reliable enough: it has false positives / known issues / accepted issues. Users (I guess Thomas and I, maybe some subtree maintainers) keep a local reference of this script output, and compare against it. This is something that is rarely needed: in general additions are done as a single component in MAINTAINERS, so people naturally add themselves with the top level directory, and that's it. So I guess our current check is good enough. > > either way i'll fix that up, sorry for the mistake. No worries, this is not something you could easily find unless grepping and looking how things were done for other unit tests. -- David Marchand