From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 5CBA21B136 for ; Tue, 2 Apr 2019 23:21:31 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id f15so8671947vsk.9 for ; Tue, 02 Apr 2019 14:21:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mj5P9/n73/oqSeQaPXiTXf6LEqRb8g2MBQUpF2tIryg=; b=ceUNa46SqPKVHwp/SAXhFmduru8HnTBHexgQnvMungh4V+vpMfRwyvy9PFV4mNNfSR /BnZAy6RadlkJVtFCx9F84KdQFYi0NBME9wSHbWF+tjDWZ6O59DGs3o4QwcsbAYqADv2 psEJt+sjWMtgnA1SUEWEEUaENozps77F6cn/OAM/nU70vx/fcW9JHh6+spJ60BKCSWdI Bw49ZqyHrWLi1DTb5ByxUseb12GFUO90w0ioPWu/qTK3rsi6JEz5stf/JLZZa9nRHOa+ GrEJcEabkEWS3hzetXtJQrk6ubZ75vTnsh1tGMwCN2hn+TjwlpMPyhfeDw4LkSKHRieI gPWg== X-Gm-Message-State: APjAAAWm0OFUlfco/wI38nSuGbj2BHtNAuJmNQRlrhBJhycHAKuJwKwJ otZCGEZ+lXOdjz95/DbJKBaZWRVkiKVi/azOeJEfiQ== X-Google-Smtp-Source: APXvYqwuQpacdlkj3y7+qjpKPFWUoPm5TIpXCom+k+w8j8jQf1ZvLa4FX2keQoEYqUvYZkKl7MCxmkyB/J1A+0BxvMY= X-Received: by 2002:a05:6102:199:: with SMTP id r25mr21804502vsq.166.1554240090735; Tue, 02 Apr 2019 14:21:30 -0700 (PDT) MIME-Version: 1.0 References: <20190326192556.19934-1-stephen@networkplumber.org> <20190402155722.21400-1-stephen@networkplumber.org> <20190402134800.789bd9bf@shemminger-XPS-13-9360> <20190402140701.058d983c@shemminger-XPS-13-9360> In-Reply-To: <20190402140701.058d983c@shemminger-XPS-13-9360> From: David Marchand Date: Tue, 2 Apr 2019 23:21:19 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 21:21:31 -0000 On Tue, Apr 2, 2019 at 11:07 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Tue, 2 Apr 2019 23:03:06 +0200 > David Marchand wrote: > > > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < > > stephen@networkplumber.org> wrote: > > > > > On Tue, 2 Apr 2019 22:15:40 +0200 > > > David Marchand wrote: > > > > > Well, I understand this is not clean, but this patch breaks the > API. > > > > > > The lcore state was marked as internal in the header file, code that > > > ignores that is going to have problems. The values are the same. > > > > > > We could defer this to 19.11 (next LTS) since it is cosmetic. > > > > > > > We must announce it before changing. > > I disagree, if an API is marked as internal it can be changed at any > time (as long as ABI is maintained). > rte_launch.h is exposed to applications. And specifically, for rte_eal_get_lcore_state(): /** * Get the state of the lcore identified by slave_id. * * To be executed on the MASTER lcore only. * * @param slave_id * The identifier of the lcore. * @return * The state of the lcore. */ enum rte_lcore_state_t rte_eal_get_lcore_state(unsigned slave_id); I don't see where this is marked as internal. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5CD93A0679 for ; Tue, 2 Apr 2019 23:21:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBDCB1B138; Tue, 2 Apr 2019 23:21:32 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 5CBA21B136 for ; Tue, 2 Apr 2019 23:21:31 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id f15so8671947vsk.9 for ; Tue, 02 Apr 2019 14:21:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mj5P9/n73/oqSeQaPXiTXf6LEqRb8g2MBQUpF2tIryg=; b=ceUNa46SqPKVHwp/SAXhFmduru8HnTBHexgQnvMungh4V+vpMfRwyvy9PFV4mNNfSR /BnZAy6RadlkJVtFCx9F84KdQFYi0NBME9wSHbWF+tjDWZ6O59DGs3o4QwcsbAYqADv2 psEJt+sjWMtgnA1SUEWEEUaENozps77F6cn/OAM/nU70vx/fcW9JHh6+spJ60BKCSWdI Bw49ZqyHrWLi1DTb5ByxUseb12GFUO90w0ioPWu/qTK3rsi6JEz5stf/JLZZa9nRHOa+ GrEJcEabkEWS3hzetXtJQrk6ubZ75vTnsh1tGMwCN2hn+TjwlpMPyhfeDw4LkSKHRieI gPWg== X-Gm-Message-State: APjAAAWm0OFUlfco/wI38nSuGbj2BHtNAuJmNQRlrhBJhycHAKuJwKwJ otZCGEZ+lXOdjz95/DbJKBaZWRVkiKVi/azOeJEfiQ== X-Google-Smtp-Source: APXvYqwuQpacdlkj3y7+qjpKPFWUoPm5TIpXCom+k+w8j8jQf1ZvLa4FX2keQoEYqUvYZkKl7MCxmkyB/J1A+0BxvMY= X-Received: by 2002:a05:6102:199:: with SMTP id r25mr21804502vsq.166.1554240090735; Tue, 02 Apr 2019 14:21:30 -0700 (PDT) MIME-Version: 1.0 References: <20190326192556.19934-1-stephen@networkplumber.org> <20190402155722.21400-1-stephen@networkplumber.org> <20190402134800.789bd9bf@shemminger-XPS-13-9360> <20190402140701.058d983c@shemminger-XPS-13-9360> In-Reply-To: <20190402140701.058d983c@shemminger-XPS-13-9360> From: David Marchand Date: Tue, 2 Apr 2019 23:21:19 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402212119.KLhBsNAMPBzLQsSkutcqpPW0W8SR90kAz9DKtmdCG38@z> On Tue, Apr 2, 2019 at 11:07 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Tue, 2 Apr 2019 23:03:06 +0200 > David Marchand wrote: > > > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < > > stephen@networkplumber.org> wrote: > > > > > On Tue, 2 Apr 2019 22:15:40 +0200 > > > David Marchand wrote: > > > > > Well, I understand this is not clean, but this patch breaks the > API. > > > > > > The lcore state was marked as internal in the header file, code that > > > ignores that is going to have problems. The values are the same. > > > > > > We could defer this to 19.11 (next LTS) since it is cosmetic. > > > > > > > We must announce it before changing. > > I disagree, if an API is marked as internal it can be changed at any > time (as long as ABI is maintained). > rte_launch.h is exposed to applications. And specifically, for rte_eal_get_lcore_state(): /** * Get the state of the lcore identified by slave_id. * * To be executed on the MASTER lcore only. * * @param slave_id * The identifier of the lcore. * @return * The state of the lcore. */ enum rte_lcore_state_t rte_eal_get_lcore_state(unsigned slave_id); I don't see where this is marked as internal. -- David Marchand