Re: [dpdk-dev] [PATCH] app/test: decrease iterations in reciprocal division test

[David Marchand <david.marchand@redhat.com>]

On Wed, Oct 23, 2019 at 7:26 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Decrease max iterations in reciprocal division test to reduce the
> runtime.
> Update fast_test_names to include reciprocal division.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  app/test/meson.build                | 2 +-
>  app/test/test_reciprocal_division.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 2c23c6347..fa4945189 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -197,6 +197,7 @@ fast_test_names = [
>          'per_lcore_autotest',
>          'prefetch_autotest',
>          'rcu_qsbr_autotest',
> +        'reciprocal_division',
>          'red_autotest',
>          'ring_autotest',
>          'ring_pmd_autotest',
> @@ -243,7 +244,6 @@ perf_test_names = [
>          'memcpy_perf_autotest',
>          'hash_perf_autotest',
>          'timer_perf_autotest',
> -        'reciprocal_division',
>          'reciprocal_division_perf',
>          'lpm_perf_autotest',
>          'red_all',
> diff --git a/app/test/test_reciprocal_division.c b/app/test/test_reciprocal_division.c
> index 8ea9b1d24..bea021972 100644
> --- a/app/test/test_reciprocal_division.c
> +++ b/app/test/test_reciprocal_division.c
> @@ -13,7 +13,7 @@
>  #include <rte_random.h>
>  #include <rte_reciprocal.h>
>
> -#define MAX_ITERATIONS (1ULL << 32)
> +#define MAX_ITERATIONS (1ULL << 16)
>  #define DIVIDE_ITER    (100)
>
>  static int
> --
> 2.17.1
>

Before patch:

Started: Thu Oct 24 08:57:19 EDT 2019

RTE>>reciprocal_division
Validating unsigned 32bit division.
Validating unsigned 64bit division.
Validating unsigned 64bit division with 32bit divisor.
Division failed, 15093057378844257455/14466 = expected
1043346977661015 result 1043346977661016
Validating division by power of 2.
Test Failed

Ended: Thu Oct 24 09:01:51 EDT 2019


After patch:

Started: Thu Oct 24 09:08:58 EDT 2019

RTE>>reciprocal_division
Validating unsigned 32bit division.
Validating unsigned 64bit division.
Validating unsigned 64bit division with 32bit divisor.
Validating division by power of 2.
Test OK

Ended: Thu Oct 24 09:08:58 EDT 2019

This is quicker, but if we don't have the right coverage, this is a -1 for me.


-- 
David Marchand