From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com
Subject: Re: [PATCH v2 0/4] Enhance headers check
Date: Wed, 16 Oct 2024 22:40:03 +0200 [thread overview]
Message-ID: <CAJFAV8z=Ue2DS4Aoio2hzi2Kji_gGCLMv6mZ3KNECo2+0n4S=Q@mail.gmail.com> (raw)
In-Reply-To: <20241016113817.3956187-1-david.marchand@redhat.com>
On Wed, Oct 16, 2024 at 1:38 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> We currently check that exported headers are fine with
> -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API.
>
> Such a check won't catch issues like the one fixed in patch 1, where OVS
> compilation is broken by the additional of experimental API in a header
> commonly included in other parts of DPDK.
>
> Ideally, I would like to merge patch 1 in rc1.
> The patch 2 is not a real issue (more like the enhanced check would
> complain about this header).
> In any case, I think it would not hurt merging everything now.
Applied patch 1 and 3.
I will respin the series (or come up with a different fix for patch 2) for rc2.
--
David Marchand
prev parent reply other threads:[~2024-10-16 20:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:10 [PATCH 0/3] " David Marchand
2024-10-15 12:10 ` [PATCH 1/3] bitops: fix build for GCC without experimental API David Marchand
2024-10-15 12:47 ` Morten Brørup
2024-10-15 12:10 ` [PATCH 2/3] bitset: " David Marchand
2024-10-15 12:53 ` Morten Brørup
2024-10-15 14:13 ` Thomas Monjalon
2024-10-15 14:44 ` Morten Brørup
2024-10-15 19:58 ` Thomas Monjalon
2024-10-15 20:30 ` Morten Brørup
2024-10-15 12:10 ` [PATCH 3/3] buildtools/chkincs: check headers with stable API only David Marchand
2024-10-16 11:38 ` [PATCH v2 0/4] Enhance headers check David Marchand
2024-10-16 11:38 ` [PATCH v2 1/4] bitops: fix build for GCC without experimental API David Marchand
2024-10-16 11:38 ` [PATCH v2 2/4] bitset: " David Marchand
2024-10-16 14:14 ` Mattias Rönnblom
2024-10-16 15:36 ` David Marchand
2024-10-16 15:42 ` Morten Brørup
2024-10-16 16:03 ` Mattias Rönnblom
2024-10-16 16:17 ` Thomas Monjalon
2024-10-16 15:51 ` Mattias Rönnblom
2024-10-16 11:38 ` [PATCH v2 3/4] vhost: remove internal vDPA API description from public header David Marchand
2024-10-16 11:47 ` Maxime Coquelin
2024-10-16 11:38 ` [PATCH v2 4/4] buildtools/chkincs: check headers with stable API only David Marchand
2024-10-16 20:40 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z=Ue2DS4Aoio2hzi2Kji_gGCLMv6mZ3KNECo2+0n4S=Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).