From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEA46A04B4; Fri, 8 Nov 2019 14:45:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6FD91C1BA; Fri, 8 Nov 2019 14:45:56 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 186CA1C1B9 for ; Fri, 8 Nov 2019 14:45:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573220754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yCU+5Fvh+itYyQsICjFl9Sb5apjiQlzEjHmSGoIAVU=; b=VNdibDkHY9GRzX9Tw2jEVUdSqSokKJvxYFR9rBIDO7PeTriuaVojkbYFIgBAAjQF2vFS55 dRovAb3CHwgeHgJEQA8d+lfimSq7X5YVFw5792VfkG5ib2kdX48aAt6BsQnPdbm8ZTG+LE +cAXHRdlRepmEF3szJ6xKvCVp1H4Gis= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-_HltT1b4MH-OWXHtHe2oYg-1; Fri, 08 Nov 2019 08:45:53 -0500 Received: by mail-ua1-f70.google.com with SMTP id n21so2322892uaq.14 for ; Fri, 08 Nov 2019 05:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fiD7qp4Tq0HC7tyuEdXDwvJUexFltKkFitM07NYEEWw=; b=tYCAlbrxpnUNOMhKeUJlrqQfV95TAw9JTeAqjunii1PJN3bJSaMrQydDPfWkifiPWQ pNqWzRqrohO0eGmCQxfMNNnwuZEF4cIHoE1EuBLMLGnP+Rku++tg4ntygAM0UtXElcPc Nj1Ge57pegTRieL29Y7rpRKQoCgp0kpgQU1R+WGA0PyoJP9UehhpJ54KBCXNIyeqU85l 7Eagm6hdeIwyTL2mYqo7FAY0+6lGMyc9yYtR1mTKHuUaZqVXMVfb64r/HN6V8cW9x9hs evG9hlFd/R31yHPzgorsk11G9+iMPnovHHECnPKAs7ir5+DgOIXsteOh81ZrIrYygEP0 og5g== X-Gm-Message-State: APjAAAUnz1kTWQBL/gZSoDyGe5ollhYpktum06hzLKEZzatdKp1yclLG 5sWEGtR8f6++JLnciq+w6aTdkJKkvxxNqHNijGMuBYMgGZbt+4J/pPBmFJe207nvH+RY2QGyeYU FSYa7pE5SrhDiFSX3HX8= X-Received: by 2002:a67:bd05:: with SMTP id y5mr8192674vsq.180.1573220752462; Fri, 08 Nov 2019 05:45:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzHpLgnJFsUzKgN2mYhLQJF1ZM2MJ9CRGpA1ixe3LpNruuBuSaHMpi4opc0kOLWFzmZHOVhHvGQv0tqx6whYIM= X-Received: by 2002:a67:bd05:: with SMTP id y5mr8192629vsq.180.1573220751970; Fri, 08 Nov 2019 05:45:51 -0800 (PST) MIME-Version: 1.0 References: <20191108102135.7249-1-kkanas@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 8 Nov 2019 14:45:41 +0100 Message-ID: To: Krzysztof Kanas Cc: dev , "Yigit, Ferruh" , Bruce Richardson X-MC-Unique: _HltT1b4MH-OWXHtHe2oYg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutf= f. > > Rest I will address here. > > > > > > > > > + const char *procdir =3D "/proc/self/fd/"; > > > > > > self is a Linux thing. > > > This won't work on FreeBSD. > > > > IMHO original code didn't worked on FreeBSD as well. > > I have created function to adress in third patch > > Indeed... > > Well, wait. > Why do we need to close those file descriptors? > FreeBSD has been like this for quite some time. We don't know what this is used for. We know it does not work on FreeBSD, but this does not seem to be a problem= . Introducing something more on FreeBSD is a risk with no actual benefit at first sight. Either we take only the first patch under a #ifdef EXEC_ENV_LINUX or we leave this as is. Krzystof, is this a problem for you if we postpone and investigate further for 20.02? --=20 David Marchand