From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>,
dev <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input
Date: Wed, 29 Jan 2020 18:44:43 +0100 [thread overview]
Message-ID: <CAJFAV8z=csSDwe1YUDPQu1mxzBgv5=fWm2=0tZvF3r-uF4-O-w@mail.gmail.com> (raw)
In-Reply-To: <1689bec2-91f3-77cd-8604-f7123023b109@intel.com>
On Tue, Jan 28, 2020 at 6:35 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote:
> > In current version, there is a function which parses
> > the corelist based on user value. A new generic
> > function eal_parse_optionlist is added which will
> > parse corelist as well as similar user input so
> > that we can use it as a public API too.
> >
> > Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
>
> Hi David,
>
> Overall this patchset is to add '--portlist' command to testpmd and remove
> existing 64 port limitation.
>
> And in this patch re-uses the exiting parser function in eal and converts it to
> API, question is if eal is good place to have this API, what do you think about it?
Exporting string parsers from the EAL has little value.
Ok we avoid code duplication (and I can see other places in the tree
where it might be used), but in the end we will have to maintain this
API in the ABI when it enters the stable ABI.
I am for avoiding this.
--
David Marchand
next prev parent reply other threads:[~2020-01-29 17:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 10:30 [dpdk-dev] [PATCH 0/2] app/testpmd: add portlist option to the testpmd Hariprasad Govindharajan
2020-01-27 10:30 ` [dpdk-dev] [PATCH 1/2] " Hariprasad Govindharajan
2020-01-31 16:22 ` [dpdk-dev] [PATCH v2] " Hariprasad Govindharajan
2020-01-31 17:41 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
2020-02-03 16:53 ` [dpdk-dev] [PATCH v4] " Hariprasad Govindharajan
2020-02-04 16:48 ` [dpdk-dev] [PATCH v5] " Hariprasad Govindharajan
2020-02-05 10:42 ` Ferruh Yigit
2020-02-06 15:03 ` [dpdk-dev] [PATCH v6] " Hariprasad Govindharajan
2020-02-10 17:19 ` [dpdk-dev] [PATCH v7] app/testpmd: add portlist option Hariprasad Govindharajan
2020-02-11 12:00 ` Burakov, Anatoly
2020-02-11 15:37 ` Govindharajan, Hariprasad
2020-02-11 15:52 ` [dpdk-dev] [PATCH v8] " Hariprasad Govindharajan
2020-02-11 16:51 ` Burakov, Anatoly
2020-02-12 10:25 ` Govindharajan, Hariprasad
2020-02-12 10:29 ` [dpdk-dev] [PATCH v9] " Hariprasad Govindharajan
2020-02-12 13:03 ` Burakov, Anatoly
2020-02-12 13:59 ` Ferruh Yigit
2020-02-12 17:27 ` Lipiec, Herakliusz
2020-02-13 11:31 ` Ferruh Yigit
2020-01-27 10:30 ` [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input Hariprasad Govindharajan
2020-01-28 17:35 ` Ferruh Yigit
2020-01-29 17:44 ` David Marchand [this message]
2020-01-29 18:07 ` Ferruh Yigit
2020-01-29 19:19 ` Stephen Hemminger
2020-01-31 11:25 ` Govindharajan, Hariprasad
2020-01-31 14:42 ` Govindharajan, Hariprasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z=csSDwe1YUDPQu1mxzBgv5=fWm2=0tZvF3r-uF4-O-w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hariprasad.govindharajan@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).