From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ECECA0561; Thu, 4 Mar 2021 11:39:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62B6140693; Thu, 4 Mar 2021 11:39:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id BB35340693 for ; Thu, 4 Mar 2021 11:39:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614854368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=09EzrQ/8ytxGWC3Ta7osLZLNRCju+2bSlWAsrsWyDXw=; b=LqMUW2zkwxhQX0eeIFjghM61oa9fgya85VWvBcWzfQKcRzRkzf83eCMxCfSrCBrpBViQ7l /HluyoAqMsSn8ESxlD2xSpzg7VCANfohYkSIMqS/ZO1ZEZS1X0GtqV6bUIGas/ngfMeVie Q/hFhy0ocQPLyMHNH3iwOhk7lGHy4n4= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-SLPxBEL9MiWxqFQ1y8PPrA-1; Thu, 04 Mar 2021 05:39:24 -0500 X-MC-Unique: SLPxBEL9MiWxqFQ1y8PPrA-1 Received: by mail-vk1-f199.google.com with SMTP id x190so7457022vkd.12 for ; Thu, 04 Mar 2021 02:39:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=09EzrQ/8ytxGWC3Ta7osLZLNRCju+2bSlWAsrsWyDXw=; b=JAgnvsS7O/o0bNZJo1fn9i+4cDqxmm0zTOGEoE58t69UhjbdIzIo0sCdyRXQyD/A/w 8MaHlXxZrr0Ygf78MlhCz8ybiVdX2kdR9gRR+iU+IzZ3MHZsEzb5oPSGzaBuH+WqrKHA uiydBFzx8IaobrLh4xlV2truEKtQ55j0ZutyClMDp7QSvfEcvTSEp0vuBIfU/0VbNVmh 9G5sqHZczmYfVlZXrkPcLTx2GSmq1uRrKx5gcVomVnzd32u4VgL9IIcpGTYte6z93BAe XiQlYbhYxJwxAnb3T1EH9ClCq888UjRxA/myeUa5Ed6HW1rWtlcJMMq0vsRiVRwElH4c obug== X-Gm-Message-State: AOAM530ZIejEDTu+9IZjq2xHva5LRp0d1kOi9FfM8UJTBSu90zgMnxg5 uVO9fX4fTMzCAwNIP3I7YCD6mgNTGzgEObDUvDC+xriZ47rOyTEzDa9H6wTMEMrzzntV3NhtVM2 5kmy50xQRXcKrZw0+dvo= X-Received: by 2002:ab0:1849:: with SMTP id j9mr1710386uag.41.1614854363993; Thu, 04 Mar 2021 02:39:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmPvrQRL6lXxQLBlMYCu9VMTRXA4ndYULcIOKwotwvSw0tBVUjmyrouw57hBVMOAgYSnooGORqgRckLL/FXfo= X-Received: by 2002:ab0:1849:: with SMTP id j9mr1710382uag.41.1614854363844; Thu, 04 Mar 2021 02:39:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 4 Mar 2021 11:39:12 +0100 Message-ID: To: Anatoly Burakov Cc: dev , dpdk stable , Andrew Boyer Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov wrote: > > When file truncation fails, the log message attempts to print a path of > file we failed to truncate, but this path was never set to anything and, > what's worse, was uninitialized. Fix it by passing path from the caller. > Coverity issue: 366122 > Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") > Cc: stable@dpdk.org Reported-by: Andrew Boyer > Signed-off-by: Anatoly Burakov Reviewed-by: David Marchand Applied, thanks. -- David Marchand