From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1683CA0A0C; Fri, 2 Jul 2021 15:56:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 869B041363; Fri, 2 Jul 2021 15:56:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A2D0341353 for ; Fri, 2 Jul 2021 15:56:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625234161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A0GxPNL6/m8ituFRn+qJtbOkmqk2TcFNyGqmSqOoJf4=; b=bcQz9u9uIKI+WFgWTqJ+cmhRr/nMn8cCw0jV3uVqqlvnRofHkjO0SaC4T7jFODx3njrCZc jIw/bVJcx2/ErSmx5nOJnXE0WgjB6NVQ6ifEttXnDyTHQoDxARUeef2eBjg3Ms5u8TyQ1m FudkapxPjU5drKEsZPUzqAov5BEwiH4= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-oOxw83FYMM2trkMntO8oKA-1; Fri, 02 Jul 2021 09:56:00 -0400 X-MC-Unique: oOxw83FYMM2trkMntO8oKA-1 Received: by mail-vs1-f70.google.com with SMTP id p15-20020a67f40f0000b0290283ad66df5eso1661283vsn.13 for ; Fri, 02 Jul 2021 06:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A0GxPNL6/m8ituFRn+qJtbOkmqk2TcFNyGqmSqOoJf4=; b=Wp+3m+9Fdft6hn8ORZGoUAM3aSFCeiJFQd7oeXXyM0kRDWAIo13Uf5F/Ux7q0B7ytp B/L/LuJbapBJNm5fyHjLKW9VLTaXvjAj3A/QFRO9G1C8ANVYD1m8Oy+/35iEghGvhSok Ii82SUW6DPwTt9be0fy433flP/Oyy5XB1Z90lLdlVQiPugIb1XCEQINmhZr377T8Na2Z XoUeYdUhYxaB7LuFMOWIHww+JNINrAvqa4jKB75LhaHHAAShK453MW/kPg2LJl3IDkfZ 021TIP7EISiIcqt1PfS9Um0QhfWJEMV7ShA7SBcmq98/snxvTZPAvWM5pmb75zDt5Pry jnCA== X-Gm-Message-State: AOAM532aXIJP+MGK0yv/Bq80ePfbFJcjn4f//wcZqzkhvKVlaERwbfUP 37gfu9Thk9PYZ+XUpaUq8D1vX+0+TVd9r6vZA0MfvZL/vkhJFhhOzsunneMGs7+QM5DS2uA1lpR UQy0ZuPuQI2X+vHT/7v4= X-Received: by 2002:a67:c513:: with SMTP id e19mr6576687vsk.18.1625234160235; Fri, 02 Jul 2021 06:56:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2I48Ja4y38sPyE5AAch+EjTVBGJiUZULRp760A4k6+uZJTygCLmvoiL+KN4eRt4mdIOV2WLEBM6HrgVoz6VQ= X-Received: by 2002:a67:c513:: with SMTP id e19mr6576664vsk.18.1625234160074; Fri, 02 Jul 2021 06:56:00 -0700 (PDT) MIME-Version: 1.0 References: <20210430043424.19752-1-apeksha.gupta@nxp.com> <20210430043424.19752-2-apeksha.gupta@nxp.com> In-Reply-To: From: David Marchand Date: Fri, 2 Jul 2021 15:55:48 +0200 Message-ID: To: Apeksha Gupta Cc: Andrew Rybchenko , "Yigit, Ferruh" , dev , Hemant Agrawal , Sachin Saxena Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 8, 2021 at 3:10 PM Andrew Rybchenko wrote: > > +RTE_PMD_REGISTER_VDEV(ENETFEC_NAME_PMD, pmd_enetfec_drv); > > +RTE_PMD_REGISTER_PARAM_STRING(ENETFEC_NAME_PMD, ENET_VDEV_GEM_ID_ARG "="); > > + > > +RTE_INIT(enetfec_pmd_init_log) > > +{ > > + enetfec_logtype_pmd = rte_log_register("pmd.net.enetfec"); > > + if (enetfec_logtype_pmd >= 0) > > + rte_log_set_level(enetfec_logtype_pmd, RTE_LOG_NOTICE); > > rte_log_register_type_and_pick_level() should be used. > > > +} Please prefer RTE_LOG_REGISTER_DEFAULT(). Thanks. -- David Marchand