DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net
Subject: Re: [PATCH 3/5] build: remove unnecessary version checks
Date: Tue, 8 Oct 2024 10:33:56 +0200	[thread overview]
Message-ID: <CAJFAV8zAzBfHDY-66moJ=PZnShaFJHG1k8fV=y_A3sNJqAF0-A@mail.gmail.com> (raw)
In-Reply-To: <20240920125737.1197969-4-bruce.richardson@intel.com>

On Fri, Sep 20, 2024 at 2:58 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Since minimum meson version is now 0.57 we can remove all version checks
> for versions lower than that.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  config/meson.build  | 2 +-
>  doc/api/meson.build | 2 +-
>  drivers/meson.build | 3 ---
>  lib/meson.build     | 6 ------
>  4 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 8c8b019c25..913825b1ca 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -97,7 +97,7 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
>  if not is_windows
>      meson.add_install_script('../buildtools/symlink-drivers-solibs.sh',
>              get_option('libdir'), pmd_subdir_opt)
> -elif meson.version().version_compare('>=0.55.0')
> +else
>      # 0.55.0 is required to use external program with add_install_script

Nit: this comment can be removed (I intend to do when applying).


>      meson.add_install_script(py3,
>              files('../buildtools/symlink-drivers-solibs.py'),


-- 
David Marchand


  reply	other threads:[~2024-10-08  8:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 12:57 [PATCH 0/5] Increase minimum meson version Bruce Richardson
2024-09-20 12:57 ` [PATCH 1/5] build: increase minimum meson version to 0.57 Bruce Richardson
2024-10-15  8:16   ` Robin Jarry
2024-09-20 12:57 ` [PATCH 2/5] build: remove version check on compiler links function Bruce Richardson
2024-10-15  8:16   ` Robin Jarry
2024-09-20 12:57 ` [PATCH 3/5] build: remove unnecessary version checks Bruce Richardson
2024-10-08  8:33   ` David Marchand [this message]
2024-10-15  8:17   ` Robin Jarry
2024-09-20 12:57 ` [PATCH 4/5] build: use version file support from meson Bruce Richardson
2024-10-15  8:17   ` Robin Jarry
2024-09-20 12:57 ` [PATCH 5/5] build: replace deprecated meson function Bruce Richardson
2024-10-15  8:17   ` Robin Jarry
2024-09-21 23:21 ` [PATCH 0/5] Increase minimum meson version Ferruh Yigit
2024-09-23  1:59 ` fengchengwen
2024-09-23  2:19   ` fengchengwen
2024-09-30 20:55 ` Tyler Retzlaff
2024-10-08  8:28 ` David Marchand
2024-10-08 19:49   ` [OS-Team] [dpdklab] " Patrick Robb
2024-10-08 20:04     ` Bruce Richardson
2024-10-09 14:27       ` Patrick Robb
2024-10-09  1:04   ` zhoumin
2024-10-09 14:31     ` Patrick Robb
2024-10-14  1:24       ` zhoumin
2024-10-16 13:08         ` Patrick Robb
2024-10-17  5:26           ` Patrick Robb
2024-10-17  7:53 ` David Marchand
2024-10-17 10:04   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zAzBfHDY-66moJ=PZnShaFJHG1k8fV=y_A3sNJqAF0-A@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).