From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F48C43B6C; Tue, 5 Mar 2024 13:14:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3BBE410E7; Tue, 5 Mar 2024 13:14:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E54CD40648 for ; Tue, 5 Mar 2024 13:14:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709640866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B/qKncODpZcj0sw4u3sKjfX1KgGjcycayILi/LL19zY=; b=dBxj0oLh8NVVGx/7G85V3bXazJ/9U1XAvTuRgOn7WlFaCgJcxJPNSeHNSDGF1IynRuEbAm ZfmRUDgHnVpevxvXZPivIMQMZ2ufeicwsDjtRC8M1FjYrDEGbqbKZMPv/J+s5OElQWD43m NIZvfcVT5YEBGLvE3jSndMZreMTLdQE= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-JVx2kCrzOLmTOCW_it53Gw-1; Tue, 05 Mar 2024 07:14:25 -0500 X-MC-Unique: JVx2kCrzOLmTOCW_it53Gw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50e55470b49so7644846e87.0 for ; Tue, 05 Mar 2024 04:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709640863; x=1710245663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B/qKncODpZcj0sw4u3sKjfX1KgGjcycayILi/LL19zY=; b=scRzcu9Ti3LMIr3BDv37y3Dy2Q4CM+03SQUQhW/QxVdHw6XyB8rT9vSSqteG1ssLm8 VaiYp/ETTkKobP8x3XyTKRNhLw9oGrWfCfe8+V2WPVc3DsblCeVxm4wUf0xosjvKU256 rZTy0+wsGnHaNqRQO4u/4Ocw1Uia0ATLcK9okl+4u+WJ89yRdut7SJSAzQgLJ6Kj+H+Z l2WSJiMVpI0R4O874w3znganytV6ZkaMThdWLll9/gppsWlq64+EIouSkn2kQuKfKsdy kl0YZoXpgCyV0iPZFtp+9LHm5fi6uwBDxgBUkXTQNBXgAp7Njm0fwqiwDedsYikLEKKr i6Wg== X-Gm-Message-State: AOJu0YyVxXVRjMSKo5uZLrSHhFPNaExznA+T492y/76Z22TB5m2/VDaX oTr8e+N6FJYiRzkfxbuNzwvNBhvWW5DJhiMbHhakDEQWF/TIbt7tI7g71ZXTAQFChPhdVpW08QW uBS9xLRwOOE5DmrwZa9eg7PrYEJlZY4jRo0jGerWhQENLbtFn8faYDm8Nsx5lrTB38mpygh1HHA qr0JP//t5a5aU/crI= X-Received: by 2002:a19:9115:0:b0:513:2347:4988 with SMTP id t21-20020a199115000000b0051323474988mr1092012lfd.12.1709640863584; Tue, 05 Mar 2024 04:14:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFN7uaaF7u6LFFIYSJx+IzzI/dZmTPuxogqeq9wOa8EoRjZzPJ8sxTFTrgPpKxRz3G/+vLQAXWBMzhWHZ8H7WY= X-Received: by 2002:a19:9115:0:b0:513:2347:4988 with SMTP id t21-20020a199115000000b0051323474988mr1092000lfd.12.1709640863158; Tue, 05 Mar 2024 04:14:23 -0800 (PST) MIME-Version: 1.0 References: <20240305103640.3051399-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 5 Mar 2024 13:14:10 +0100 Message-ID: Subject: Re: [PATCH] argparse: add version in symbols map To: fengchengwen Cc: dev@dpdk.org, Bruce Richardson , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 5, 2024 at 12:35=E2=80=AFPM fengchengwen wrote: > > Acked-by: Chengwen Feng > > BTW: which tool detects this problem? I found out about those issues while manually inspecting the changes on **/version.map since v23.11. At the moment, there is no tool enforcing that experimental symbols must be in a block with a version comment. Adding a check could be done: $ git diff diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list-symbol.sh index a834399816..b76e2417c5 100755 --- a/buildtools/map-list-symbol.sh +++ b/buildtools/map-list-symbol.sh @@ -61,8 +61,12 @@ for file in $@; do if (current_section =3D=3D "") { next; } - if ("'$version'" !=3D "" && "'$version'" !=3D current_versi= on) { - next; + if ("'$version'" !=3D "") { + if ("'$version'" =3D=3D "unset" && current_version = !=3D "") { + next; + } else if ("'$version'" !=3D "unset" && "'$version'" !=3D current_version) { + next; + } } gsub(";",""); if ("'$symbol'" =3D=3D "all" || $1 =3D=3D "'$symbol'") { And it catches more issues: $ find lib -name 'version.map' -exec ./buildtools/map-list-symbol.sh -S EXPERIMENTAL -V unset {} \; lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_encode_json_format lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_reg_all_ethdev lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_global_stats lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_port_stats_ids lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_ports_stats_json lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_extract_data lib/regexdev/version.map EXPERIMENTAL rte_regex_devices lib/regexdev/version.map EXPERIMENTAL rte_regexdev_attr_get lib/regexdev/version.map EXPERIMENTAL rte_regexdev_attr_set lib/regexdev/version.map EXPERIMENTAL rte_regexdev_close lib/regexdev/version.map EXPERIMENTAL rte_regexdev_configure lib/regexdev/version.map EXPERIMENTAL rte_regexdev_count lib/regexdev/version.map EXPERIMENTAL rte_regexdev_dequeue_burst lib/regexdev/version.map EXPERIMENTAL rte_regexdev_dump lib/regexdev/version.map EXPERIMENTAL rte_regexdev_enqueue_burst lib/regexdev/version.map EXPERIMENTAL rte_regexdev_get_dev_id lib/regexdev/version.map EXPERIMENTAL rte_regexdev_info_get lib/regexdev/version.map EXPERIMENTAL rte_regexdev_is_valid_dev lib/regexdev/version.map EXPERIMENTAL rte_regexdev_logtype lib/regexdev/version.map EXPERIMENTAL rte_regexdev_queue_pair_setup lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_compile_activate lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_export lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_import lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_update lib/regexdev/version.map EXPERIMENTAL rte_regexdev_selftest lib/regexdev/version.map EXPERIMENTAL rte_regexdev_start lib/regexdev/version.map EXPERIMENTAL rte_regexdev_stop lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_by_name_get lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_get lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_names_get lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_reset lib/reorder/version.map EXPERIMENTAL rte_reorder_seqn_dynfield_offset lib/mldev/version.map EXPERIMENTAL rte_ml_dequeue_burst lib/mldev/version.map EXPERIMENTAL rte_ml_dev_close lib/mldev/version.map EXPERIMENTAL rte_ml_dev_configure lib/mldev/version.map EXPERIMENTAL rte_ml_dev_count lib/mldev/version.map EXPERIMENTAL rte_ml_dev_dump lib/mldev/version.map EXPERIMENTAL rte_ml_dev_info_get lib/mldev/version.map EXPERIMENTAL rte_ml_dev_init lib/mldev/version.map EXPERIMENTAL rte_ml_dev_is_valid_dev lib/mldev/version.map EXPERIMENTAL rte_ml_dev_logtype lib/mldev/version.map EXPERIMENTAL rte_ml_dev_queue_pair_setup lib/mldev/version.map EXPERIMENTAL rte_ml_dev_selftest lib/mldev/version.map EXPERIMENTAL rte_ml_dev_socket_id lib/mldev/version.map EXPERIMENTAL rte_ml_dev_start lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stats_get lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stats_reset lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stop lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_by_name_get lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_get lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_names_get lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_reset lib/mldev/version.map EXPERIMENTAL rte_ml_enqueue_burst lib/mldev/version.map EXPERIMENTAL rte_ml_io_dequantize lib/mldev/version.map EXPERIMENTAL rte_ml_io_quantize lib/mldev/version.map EXPERIMENTAL rte_ml_model_info_get lib/mldev/version.map EXPERIMENTAL rte_ml_model_load lib/mldev/version.map EXPERIMENTAL rte_ml_model_params_update lib/mldev/version.map EXPERIMENTAL rte_ml_model_start lib/mldev/version.map EXPERIMENTAL rte_ml_model_stop lib/mldev/version.map EXPERIMENTAL rte_ml_model_unload lib/mldev/version.map EXPERIMENTAL rte_ml_op_error_get lib/mldev/version.map EXPERIMENTAL rte_ml_op_pool_create lib/mldev/version.map EXPERIMENTAL rte_ml_op_pool_free lib/argparse/version.map EXPERIMENTAL rte_argparse_parse lib/argparse/version.map EXPERIMENTAL rte_argparse_parse_type However... if you look at the other fix I sent: https://patchwork.dpdk.org/project/dpdk/patch/20240305103651.3051448-1-davi= d.marchand@redhat.com/ In this case, the symbols were added to an incorrect version block and checking this is a bit more difficult. For this, I have no simple check. --=20 David Marchand