From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83010A00C2; Wed, 2 Nov 2022 13:13:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 635E740223; Wed, 2 Nov 2022 13:13:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D98B040041 for ; Wed, 2 Nov 2022 13:13:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667391235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MeIjJ9RHj8Jj1HkHAtREEIHiImKjujU1rV7QCuUTr5M=; b=GkISljoWB57fFEQ5n3jlHOzdLEamKG6UfhnRYzJ16sHD4RNdqjYiV2kU+5/vJXq2vROixo 96xqL7mPK5cre72ARSYCyY3du5rC+Rvx0NvjWGjollrccq9kyEowqORD8PvoB+8EBzX1CA LOu3ZDgslFOwm/9g3MsElH95cMSvNlg= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-662-BWHzkvTeP6Gt-JAps2qfbQ-1; Wed, 02 Nov 2022 08:13:54 -0400 X-MC-Unique: BWHzkvTeP6Gt-JAps2qfbQ-1 Received: by mail-pl1-f197.google.com with SMTP id u8-20020a17090341c800b0018731b83fe4so4216291ple.16 for ; Wed, 02 Nov 2022 05:13:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MeIjJ9RHj8Jj1HkHAtREEIHiImKjujU1rV7QCuUTr5M=; b=zmhdyzCYnZP5SHlvWu+81PcRQgQnSQCa8LIffEyj1nd4dES50eSF/lSs30zdPwH87H ZCqLkp8RtH7wVgYcdAkYSqyg6b0/4ii5lz0g2pZnIIW/hjO3O7K9Opry3xEl/P8AgOXB rZUq74SNNmVWgjpVfn4TMltwwsaIK4STlfexrA8RXQdsceFMgtW2nNVDyYagZntvVMy8 XbOP9f8sVZptW3BhvnvdXYq2XpiuE4FGQmrvyjeOM5fxArde0P21wgTngMGLr6HfFoTn skHicDFn/ubRG6BfY45zHRq+w4CJZT+i3Ec8Svhm47SakcSL6caMXBcPv0rNGdtbSgvJ U2fg== X-Gm-Message-State: ACrzQf1nod0rr1qgguaYAjW2J5cJ9xEBb7ZypYn9erPv+ECwTqopzN3X 588R8dPj2gUtq9Mp+2TM51S1c2kp9Te2vdd2jmSrFd5g0VVuxim7TcHLfDDnq/wEwP3BPrCZPiQ hNVrF+17/J3+UECbzpao= X-Received: by 2002:a62:b411:0:b0:56c:5afe:649f with SMTP id h17-20020a62b411000000b0056c5afe649fmr24843788pfn.60.1667391233212; Wed, 02 Nov 2022 05:13:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72TKoCaTQtWzQW/AU4/RftT4bS1IBh8sLul8PvSf3cA2rkfnqQ3lhL75BGKIQbVTw06+psK0prXNasPb5fLH8= X-Received: by 2002:a62:b411:0:b0:56c:5afe:649f with SMTP id h17-20020a62b411000000b0056c5afe649fmr24843761pfn.60.1667391232934; Wed, 02 Nov 2022 05:13:52 -0700 (PDT) MIME-Version: 1.0 References: <20220915082635.418873-1-vfialko@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 2 Nov 2022 13:13:41 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH] cryptodev: add missing algorithm strings To: Akhil Goyal Cc: Kevin Traynor , Volodymyr Fialko , "dev@dpdk.org" , Ravi Kumar , Ali Alnubani , Jerin Jacob Kollanukkaran , Anoob Joseph , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 2, 2022 at 11:58 AM Akhil Goyal wrote: > > This is being flagged as an ABI break for 21.11.3 [1]. I don't see it > > mentioned in the commit message or discussed, is it ok for main branch? > > Ok, we can keep it to main only. > But it will be an issue on 21.11. > > > > > Thanks to Ali for reporting. I will revert on 21.11 branch. > > > > [1] > > 1 Changed variable: > > > > [C] 'const char* rte_crypto_auth_algorithm_strings[]' was changed at > > rte_crypto_sym.h:372:1: > > size of symbol changed from 168 to 232 My two cents. We have a algo "string to num" helper (rte_cryptodev_get_auth_algo_enum). This code is not performance sensitive, is it? If we add the, opposite, "num to string" helper, we can hide the rte_crypto_auth_algorithm_strings symbol from the public ABI and avoid this kind of issues in the future. And looking at lib/crypto map, there are other arrays (*_strings symbols) that are subject to similar "extending" issues. We are late in the release for adding new API though such helpers would be really simple. Hiding such symbols is something to consider before entering ABI freeze. -- David Marchand