From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A8E045B5D; Thu, 17 Oct 2024 13:43:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EF2140279; Thu, 17 Oct 2024 13:43:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 930A64021E for ; Thu, 17 Oct 2024 13:43:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729165422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C/vjLGh5kZlG7q1rKcfbinb/u32IK1hMvWbvBMiSV2c=; b=H1s38aZEcDb/sLQMnJ3lBLgoZWE7XKQGWl/4poc2dv0ssDZ1IwBrRhpECyO1qN/LuedlzY UqXPKItKxEJpRvHqz4soHA3uKk1Ml1nOGmeklWEa+J37RDKzILhCjYX2j0w5IsLDF4cDdH LLbDQ1pZvviIZ7ns8a6WnJ+jCwMgUrM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-3EUyKJj1OqKWS1MOWyDFwA-1; Thu, 17 Oct 2024 07:43:41 -0400 X-MC-Unique: 3EUyKJj1OqKWS1MOWyDFwA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fb3f99c9a7so6629931fa.1 for ; Thu, 17 Oct 2024 04:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729165419; x=1729770219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C/vjLGh5kZlG7q1rKcfbinb/u32IK1hMvWbvBMiSV2c=; b=Y1ig4xHXplpIphP5ugDkU7dSxCJrQweQZBxGTlQDC3RpE0JULBesLdTJvQ+rpjoGug CuvUU0x06gB8MSD40yCy8ys19xn/pE01ES/nkBwtKSMbLXdeZB7MXo6/Tpx8desNcixh r8mvQoGV368wW10Zg/9oU3a/0WeZp2mT4Y02ZCg1snLGBjAojb1xH1OI5rFqPVDQM8Sh FNkj6Edl4/+MkVyYTHNNOYr8F3lazQUFLZmHjne47OS8yTDm9+BqS2aIsWorCSXQdevN V5LUKviYooyKGT9N9mxcmtBJQQNOYptVbwjw3QXgUOnajv0YkavE9oCTvNcM/aDOWpSf wMiw== X-Gm-Message-State: AOJu0YxM35AMiSRea/6Cy1jSDeaYGCDSeauSNvbsKJJdURiWode2vhaj sGrCM01yZxrGTny8BInXKuYrYZYBxRn8EgJEDj8S+F8FiYQTMqmitxLip2jVZuIXCPmhDvXGmkZ Kv8TP5S9YkiwAqh3aEgwlCLQMD8Kwl7mGo7isZlQ8MzMY7QhVHgIlMobp/YrbZ85kzkkmIzf5Gh QCcCS04Aq8e5RH3dI= X-Received: by 2002:a05:651c:504:b0:2fb:5f9d:c287 with SMTP id 38308e7fff4ca-2fb61ba31bcmr46691411fa.32.1729165419408; Thu, 17 Oct 2024 04:43:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTYfm3bZ0XzK9U1U/S7FNJnEttmsfJ3TwwYavRoj4SLdKeNyMRbBzbgG4vV5gWcFxSYUrJuziyHOrPlib+wtE= X-Received: by 2002:a05:651c:504:b0:2fb:5f9d:c287 with SMTP id 38308e7fff4ca-2fb61ba31bcmr46691211fa.32.1729165419035; Thu, 17 Oct 2024 04:43:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 17 Oct 2024 13:43:27 +0200 Message-ID: Subject: Re: [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit To: Anatoly Burakov , bruce.richardson@intel.com Cc: dev@dpdk.org, jaroslaw.ilgiewicz@intel.com, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 2, 2024 at 11:58=E2=80=AFAM Anatoly Burakov wrote: > > From: Jaroslaw Ilgiewicz > > Time variables were designed for 32 bit and 64 bit variables are not > necessary. Changed all to 32 bit. > > Signed-off-by: Jaroslaw Ilgiewicz > Signed-off-by: Anatoly Burakov > --- > drivers/net/i40e/base/i40e_common.c | 2 +- > drivers/net/i40e/base/i40e_nvm.c | 6 +++--- > drivers/net/i40e/base/i40e_prototype.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/= i40e_common.c > index 07e18deaea..a2cfafeda9 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -3596,7 +3596,7 @@ enum i40e_status_code i40e_aq_debug_write_register(= struct i40e_hw *hw, > enum i40e_status_code i40e_aq_request_resource(struct i40e_hw *hw, > enum i40e_aq_resources_ids resource, > enum i40e_aq_resource_access_type access, > - u8 sdp_number, u64 *timeout, > + u8 sdp_number, u32 *timeout, > struct i40e_asq_cmd_details *cmd_details) > { > struct i40e_aq_desc desc; > diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40= e_nvm.c > index 2f6cd9eda5..185af67817 100644 > --- a/drivers/net/i40e/base/i40e_nvm.c > +++ b/drivers/net/i40e/base/i40e_nvm.c > @@ -62,7 +62,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *= hw, > { > enum i40e_status_code ret_code =3D I40E_SUCCESS; > u32 gtime, timeout; > - u64 time_left =3D 0; > + u32 time_left =3D 0; Some logs (a few lines below) needs updating: i40e_debug(hw, I40E_DEBUG_NVM, "NVM acquire type %d failed time_left=3D%" PRIu64 " ret=3D%d aq_err=3D%d\n", access, time_left, ret_code, hw->aq.asq_last_status); And i40e_debug(hw, I40E_DEBUG_NVM, "NVM acquire timed out, wait %" PRIu64 " ms before trying again. status=3D%d aq_err=3D%d\n", time_left, ret_code, hw->aq.asq_last_status); Afaiu, it should be PRIu32. This was raised by OBS CI: https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debi= an_12/x86_64 --=20 David Marchand