From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84905A0562; Tue, 23 Mar 2021 14:37:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58CAF4069E; Tue, 23 Mar 2021 14:37:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 73DFD40689 for ; Tue, 23 Mar 2021 14:37:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616506662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fquO8Xmc2wkn6DXsVYPpP4BlbnsiNbo49xw2hJg3v7g=; b=ib7ynAtD4L57Giekyr2/iPEb05R69pSuPATRgT2MRilnwKzPuhJdfMEf/OyxUvIj2/RMo3 r/WHHWBAnx90d3i/C0GgcQZT3WeXvySnY8HHwifjxS8WxGSAMgORdVf7wo8xEHVhfu9hVh 63wHoxBmdeUjXB9LQvM79qqllV/FHI8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-7fe_0LxNNDKZ1EryzZQHLg-1; Tue, 23 Mar 2021 09:37:40 -0400 X-MC-Unique: 7fe_0LxNNDKZ1EryzZQHLg-1 Received: by mail-ua1-f70.google.com with SMTP id i90so366070uad.1 for ; Tue, 23 Mar 2021 06:37:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fquO8Xmc2wkn6DXsVYPpP4BlbnsiNbo49xw2hJg3v7g=; b=j1hgnYiAF/L/B/QIw0x9Uo3acuvikIL/dknztQhdZKrmrIV6fYcVPeKUpQDuh50Z+R xxb2mml9bNWYS/LB0FuqUWf72wvCOAiB0/2njqdxdcmJv4Uq1ZPbc2Brg++EoAjLdGV/ IFwHGEIa0ilSIdkPv2vtwTKU8+GDjRx+hVCvw8bD/9L8etFeGT6yZAAXBcT+Stynsntq l0I5CvJmNsp0CNupD7JJBF8ZSIplgHNuwBrKWKoBIJjDQCSjn44RhoJ7/H2Bt0Idk2vT pV+DhKJO+QVfQYfrmpaDR17SJcOtijAaoRdokYl5SNr4kXosGTabBEIkUrIbxhXC/31H QMIw== X-Gm-Message-State: AOAM533UtN3GMkuaYwQ7595VLGmgPzrAIofP8RYa5JzTRvCc97yDQ4/I fwh34Cg/7gK3qPnVjwjIbeiSRr6sqFSMbTqIFnJmZSPHosovni90ISwlXgg0DjN6Hf4IoyTOpN8 VYKF41AQezA7IIfO8/0w= X-Received: by 2002:a05:6102:3594:: with SMTP id h20mr3372967vsu.10.1616506659368; Tue, 23 Mar 2021 06:37:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybobhyotUsnfWbtO3MleeSjP0tCbF35tDAZ6L0VeovzpPNVR9udqkaa0F4RVlgT3rBRVTTNsSQBrls2McCfvA= X-Received: by 2002:a05:6102:3594:: with SMTP id h20mr3372936vsu.10.1616506659107; Tue, 23 Mar 2021 06:37:39 -0700 (PDT) MIME-Version: 1.0 References: <20210309233116.1934666-1-thomas@monjalon.net> <20210321223116.1340974-1-thomas@monjalon.net> <20210321223116.1340974-8-thomas@monjalon.net> In-Reply-To: <20210321223116.1340974-8-thomas@monjalon.net> From: David Marchand Date: Tue, 23 Mar 2021 14:37:27 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Andrew Rybchenko , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > The option --log-level was not completely described in the usage text, > and it was difficult to guess the names of the log types and levels. > > A new value "help" is accepted after --log-level to give more details > about the syntax and listing the log types and levels. > > The array "levels" used for level name parsing is replaced with > a (modified) existing function which was used in rte_log_dump(). If we forget about the slightly different formatting, why not simply reuse rte_log_dump? It has the advantage of listing the default level for each logtype that a user cannot guess otherwise. -- David Marchand