From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07247A04B5; Tue, 12 Jan 2021 09:17:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 761A5140D07; Tue, 12 Jan 2021 09:17:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 818B8140D06 for ; Tue, 12 Jan 2021 09:17:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610439473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sW/oesI1n/dFNsY7Dj4PengfWB5wS2INs3M7N0eIuzk=; b=DmWgVX53b9mgID/uE+ddRjpt0d6NySkavOACLGAbxY+zfL584QX5/3L9xWdj82U7JTK0hZ 8A0bgvW2n33VGacF+3if/JSf/9TkPUD8EBf5mae77s9DU7UoW/WTjMn3tGD85L3uadzgda /8r5DXjSJe2jZ0/X6yZMA5c9dPJpdIg= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533--_7DgSBDPpO4bkw6HA32Jg-1; Tue, 12 Jan 2021 03:17:52 -0500 X-MC-Unique: -_7DgSBDPpO4bkw6HA32Jg-1 Received: by mail-vk1-f197.google.com with SMTP id i2so720828vka.6 for ; Tue, 12 Jan 2021 00:17:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sW/oesI1n/dFNsY7Dj4PengfWB5wS2INs3M7N0eIuzk=; b=rAgYFF5+DT5Cae20+dh8CYyDCde8Ryym24M+8s9uHns/OfaSSt7EfQnlapQRfZOru9 K3uIYYKgBVbws93y8BcpxzuIqwZtGT2Cqv32L8IExHaUJ3pji40zSm/tKF01WQJdMvNS SD6ugiytfsJS374EVQmmZMqk69Ztg2CA41ztfg2uuVYH+5HvIFDakTAcRfPm0Z7FYnKx OdUw519D3I9c09KGMH1xXELlU7iFNW6CBbgcq5jBdsW7xUomi1pVThQhbzM3oXcVpk0S 6XJb0LPwKHdm443N+PbY7GBnDr1u3oDSaWDlyizs1+tsXn0lMyNY3e6eiLesl+ob/ThE 0xUg== X-Gm-Message-State: AOAM532CizCUOBPVGZiFNXoODfVrCqx1seph2daXX86RgBiRi+btpjEx 27sBipS8RkhgJmE31m8eVzEl5+5xwUfqzpiTNk/23ymFx15HzQRhAE4DTgXweDqoFbFmOQctvEq LsQ1iJQJ/usWPg7QYWHQ= X-Received: by 2002:ab0:5542:: with SMTP id u2mr2477541uaa.41.1610439471868; Tue, 12 Jan 2021 00:17:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKUzXckhtKtLaUcHeOC2WilCaIrd3MMVVyfZH5GAmZL5Bv01LeKSkvWa7ohUzXl+7t6u5gLgxQKcHP9J7IU8M= X-Received: by 2002:ab0:5542:: with SMTP id u2mr2477529uaa.41.1610439471678; Tue, 12 Jan 2021 00:17:51 -0800 (PST) MIME-Version: 1.0 References: <1610390183-22709-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Tue, 12 Jan 2021 09:17:40 +0100 Message-ID: To: Tyler Retzlaff Cc: Thomas Monjalon , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 12, 2021 at 9:14 AM David Marchand wrote: > > On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff > wrote: > > Commitlog please. > > > > > From: Tyler Retzlaff > > > > --- > > lib/librte_eal/common/meson.build | 1 + > > lib/librte_eal/rte_eal_exports.def | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build > > index 39abf7a0a..9c6f18eb8 100644 > > --- a/lib/librte_eal/common/meson.build > > +++ b/lib/librte_eal/common/meson.build > > @@ -34,6 +34,7 @@ if is_windows > > 'rte_malloc.c', > > 'eal_common_timer.c', > > 'rte_service.c', > > + 'rte_reciprocal.c', > > ) > > subdir_done() > > endif > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > > index 4597eb8cd..ba1443dc2 100644 > > --- a/lib/librte_eal/rte_eal_exports.def > > +++ b/lib/librte_eal/rte_eal_exports.def > > @@ -326,3 +326,4 @@ EXPORTS > > rte_mem_map > > rte_mem_page_size > > rte_mem_unmap > > + rte_reciprocal_value_u64 > > Looking at rte_reciprocal.c/.h and EAL version.map, this API exports > two symbols. > If there is no reason why the other symbol has been skipped, please add both: > rte_reciprocal_value > rte_reciprocal_value_u64 Dmitry made the same comments on another (unthreaded) version of this patch, so we are good. -- David Marchand