From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B134EA0524; Thu, 30 Jan 2020 11:54:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 807C51BFF6; Thu, 30 Jan 2020 11:54:28 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 22B7E1BFE6 for ; Thu, 30 Jan 2020 11:54:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580381666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iaCWUw5BCV6LcDNxon79yzrY+ThiiDIT/Az4POpX18k=; b=dOiq/iSAk+8R+yyGznrYfrTgIUl+jUQfjYCpHRVcm7qfbfUkhJZiNDtAmD8If2OEr9JzEx LVgWLsYK7LV5wq0cRJ2yqBOfthSUYukvMpyoejTDeVGW3Ccst0lNlEEnHUNAwk4SBjJI2M euPp2ybYW1+Bvg3zbstjO0fupZApF6Q= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-EGV0394ANsWf8lepM0flPw-1; Thu, 30 Jan 2020 05:54:23 -0500 Received: by mail-vk1-f197.google.com with SMTP id 128so1082694vka.12 for ; Thu, 30 Jan 2020 02:54:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d8RWQJLh4BkZGR0C1y6vYZPlqKvoTuR0zBejOmrU0qI=; b=F9QK6XQOdYk3zTLDmrFOuvwH6ofdm1kU+SobR53aOLYW8kLkfDZLFjlJrmzCxmZfWK xP1slsn88ONWGXr1dKLoBuEeX0TqCzTau2/pMHTxeSYmKZlL3AcymCreYm1ReJXN2QDW CmK7qkPGId/4UNSp8ze4KwlyCCHD/Jv3GuWx4QB9k1uEXOj9/Meke3X0OE1OISpF3EO3 gfTP0/lLRBCJLfOp0xEmFTYoku70snmoSXSf5LU3PtlSFexnkNPZqRc3BqFeY6MgGTLs mkCHSMBU9MfMNGYENkOxMOL0WoMdzdh8WCaA1khwyXfAJBP6TcPbshLgixYv3ENWJGOH XpGQ== X-Gm-Message-State: APjAAAViVjRsSAZGkod0zraoUAEIrBpCNnXQka+wHRofc7bu1TulOf9y B0ADhRV2yMBtdjuM0LEKjCjv9g2PWkKteThsIrHNh70KnM606atoeY6N3qeqpsDJtz68S2Wc818 noE0fV0KeFrgZps/f9uw= X-Received: by 2002:a67:905:: with SMTP id 5mr2710194vsj.105.1580381663129; Thu, 30 Jan 2020 02:54:23 -0800 (PST) X-Google-Smtp-Source: APXvYqy78hhROXjbX46jKXEP+9lTq1W+r1u7U4J6YdJviTdvjyG7gwUnQhDnT6eli7RIbrEcoRrXxdK1x4YJgxiv4hQ= X-Received: by 2002:a67:905:: with SMTP id 5mr2710170vsj.105.1580381662817; Thu, 30 Jan 2020 02:54:22 -0800 (PST) MIME-Version: 1.0 References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> <20200129172621.28565-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 30 Jan 2020 11:54:11 +0100 Message-ID: To: Luca Boccassi Cc: dev , Thomas Monjalon , Bruce Richardson , Kevin Laatz , Aaron Conole , Neil Horman , Akhil Goyal , Anoob Joseph , dpdk stable , Yipeng Wang , Sameh Gobriel , Harry van Haaren , Keith Wiles X-MC-Unique: EGV0394ANsWf8lepM0flPw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/4] hash: fix meson headers packaging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 30, 2020 at 11:12 AM Luca Boccassi wrote: > > On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote: > > Those headers are internal and should not be distributed. > > > > Fixes: 5b9656b157d3 ("lib: build with meson") > > Cc: > > stable@dpdk.org > > > > > > Signed-off-by: David Marchand < > > david.marchand@redhat.com > > > > > --- > > lib/librte_hash/meson.build | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/lib/librte_hash/meson.build > > b/lib/librte_hash/meson.build > > index 5d02b3084..bce11ad9e 100644 > > --- a/lib/librte_hash/meson.build > > +++ b/lib/librte_hash/meson.build > > @@ -1,10 +1,7 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -headers =3D files('rte_cmp_arm64.h', > > - 'rte_cmp_x86.h', > > - 'rte_crc_arm64.h', > > - 'rte_cuckoo_hash.h', > > +headers =3D files('rte_crc_arm64.h', > > 'rte_fbk_hash.h', > > 'rte_hash_crc.h', > > 'rte_hash.h', > > Difficult question: how confident we are nobody is using those? :-) Those headers are for internal structures. When installing with make, those headers were skipped. Grepping on the dpdk projects that I monitor (based on Stephen list): $ for header in rte_cmp_arm64.h rte_cmp_x86.h rte_cuckoo_hash.h; do echo "=3D=3D=3D=3D=3D=3D=3D $header"; git grep-all -l $header; echo; done =3D=3D=3D=3D=3D=3D=3D rte_cmp_arm64.h F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h yastack origin/HEAD:dpdk/lib/librte_hash/meson.build yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h =3D=3D=3D=3D=3D=3D=3D rte_cmp_x86.h F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h yastack origin/HEAD:dpdk/lib/librte_hash/meson.build yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h =3D=3D=3D=3D=3D=3D=3D rte_cuckoo_hash.h F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.c Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h yastack origin/HEAD:dpdk/lib/librte_hash/meson.build yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h --=20 David Marchand