From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93F01A0032; Wed, 13 Jul 2022 09:18:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83F6C4282D; Wed, 13 Jul 2022 09:18:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ECC824282B for ; Wed, 13 Jul 2022 09:18:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657696709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HFb//meVtgJbNba0rQFk6mpn797dVKtivgsbAKo68KI=; b=h7gk3tJ1lHHw+V/aiePG8N5tJgBJ7XaB9B1+Mq8gGjRuw60R/aJNENpck1a9cWQoZ2oZmc Yq9J62yW15zmZYWP3+6i+piJhpj2lkMhUvbciZC5V8aOP7X7M8ctQdB+LsrX6faPvsgvzQ rJvKFKt4+JF+DLxSO70tJBXvH3lrBb4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-8_o4MGEXNqCfJweZqmxdig-1; Wed, 13 Jul 2022 03:18:27 -0400 X-MC-Unique: 8_o4MGEXNqCfJweZqmxdig-1 Received: by mail-lf1-f69.google.com with SMTP id z13-20020a056512308d00b004811694f893so4646288lfd.6 for ; Wed, 13 Jul 2022 00:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HFb//meVtgJbNba0rQFk6mpn797dVKtivgsbAKo68KI=; b=lfkVmx7iROHlF0i31yYFFT+9V6OSvH16HTxCFxKGwS4e9V7KKESR/sI2DfHsP/8mLS 9pLnzsQ7EFOscDqTusBaIttwtDKFV72O0yKIi6nkdL4FMT7aDxk2hzLGk3eXfGsv46S1 73v8YBNdZ2uB3sjPW1mQmF2Y/04i13QauLrBvYQt+PxrvAOssZKMLi2l1DeQadr2cCF0 lUer+B+ORhlDYapFHlJzBmLdOg8aND3Mi4ll69sUlBnll36i7mrGNtbYoO/mP24BR7H1 X8lLbLEnx4txwKv1HwW37KlEgILYBfE1ciBmvhPiL7mgNPK5y1IqrpbmeQ6jMkfwYPwY sx+Q== X-Gm-Message-State: AJIora/Tx7ZgPdFGahl7RhDY4wSrnDGyCJldlyPihdkQCiaRvIK8zBYQ mXWLXOGo41sbFGdW92jP4vkNLd9/XFapQCz90Iy0Q8tDEQo/Tp4IBP8mnMtq7i3C86xhWdS6fEs Tztya6xAeBPJ01XrSkS0= X-Received: by 2002:a05:6512:3590:b0:489:ed22:4931 with SMTP id m16-20020a056512359000b00489ed224931mr1232858lfr.484.1657696705566; Wed, 13 Jul 2022 00:18:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vQ5M87BSAyN1DQfg5IPGl+0D5WNaXuKy9PZXd6xQ+lJTqQr4DhdYfPBGv0wCcybGZE2H01N8pEO0y/Ftx6J/M= X-Received: by 2002:a05:6512:3590:b0:489:ed22:4931 with SMTP id m16-20020a056512359000b00489ed224931mr1232851lfr.484.1657696705347; Wed, 13 Jul 2022 00:18:25 -0700 (PDT) MIME-Version: 1.0 References: <20220628135339.2882914-1-skori@marvell.com> In-Reply-To: <20220628135339.2882914-1-skori@marvell.com> From: David Marchand Date: Wed, 13 Jul 2022 09:18:14 +0200 Message-ID: Subject: Re: [PATCH 1/2] doc: announce region based device mapping support To: Sunil Kumar Kori Cc: Ray Kinsella , dev , "Xia, Chenbo" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 28, 2022 at 3:56 PM wrote: > > From: Sunil Kumar Kori > > Adding region based device mapping support, which enables pci device > to map only required memory region instead of mapping full BAR. > > Signed-off-by: Sunil Kumar Kori > --- > doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 4e5b23c53d..8800a3eb41 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -125,3 +125,16 @@ Deprecation Notices > applications should be updated to use the ``dmadev`` library instead, > with the underlying HW-functionality being provided by the ``ioat`` or > ``idxd`` dma drivers > + > +* pci: Update ``rte_pci_device`` and ``rte_pci_driver`` to add region based > + memory mapping support. There could be a requirement to mmap specific memory > + region only. Using this mechanism, pci device can be mapped for > + a given BAR at a given offset of given size. > + > + ``rte_pci_device`` will be added with following field > + ``regions[PCI_MAX_RESOURCE][PCI_MAX_REGION_PER_RESOURCE];``. This field will > + specify the regions which are mapped for a given BAR. > + > + ``rte_pci_driver`` will be added with ``rte_pci_region_map *regions`` and > + ``valid_bars[PCI_MAX_RESOURCE]``. Using these fields, driver can propagate > + its region information which are required to be mmap. I don't think we need a new deprecation notice for this. We still have Chenbo current notice: https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n46 Besides, my proposal hides every bus specific device representations, and I think it covers your needs too. See https://patches.dpdk.org/project/dpdk/patch/20220710061736.973563-1-david.marchand@redhat.com/ Did I miss something? -- David Marchand