From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E457A0508; Thu, 14 Apr 2022 11:51:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F44840041; Thu, 14 Apr 2022 11:51:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AAF0C4003F for ; Thu, 14 Apr 2022 11:51:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649929869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZAm6E0TNAUe/Ae1y3xt6farxSH3CxWqGIg78LxbzbSQ=; b=NkEJUYLEBT00bKUhheO66KK7ul/l5Rbpu2dIMoksqsvxJQ5TYb/RlkX0OrtPkyBn2R58u4 FRqzxuqrskc4TpTgoF8FLn300sJMKzxxS8BZfRUTmzsGXPT2RMJy2FQcW70LF82KBb8kvW GQeCzSPfDUzWRbZVRkoiq7z18euWIWc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-296-az_OERB7N2mNg3zeFMJ1yw-1; Thu, 14 Apr 2022 05:51:08 -0400 X-MC-Unique: az_OERB7N2mNg3zeFMJ1yw-1 Received: by mail-lf1-f71.google.com with SMTP id bp19-20020a056512159300b0046bac0601a3so2113391lfb.1 for ; Thu, 14 Apr 2022 02:51:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZAm6E0TNAUe/Ae1y3xt6farxSH3CxWqGIg78LxbzbSQ=; b=7ax3xHqzSDmz/DmsxhSoyne6CqTNHfcstLgq4RmeFqnRNrCcTTlbn3zSxcZMS3iLUc PzYoLN7t83/6cFnElr850jAWeC5XHnKKkdFFhBKdv8PsVBlPdFP4sCJIVoPpyZwiG6/t agQYS+LvlD0iNzJzWS9gyLJiaVrOAhyCLlAs8Qy4b2Kn4+cuFE8Uh/EK+CKlvsoCmmz7 caP9D71aUhcjLlvo8nsmiGpMQHsY2Txs0/jQag2dn39tN6wCuniflSULEQ9ez/TGfGvD BcPLckvIony5UGYFVh7EeTr1sLI5ix0IoaFTd+j4E0Q8YdIm4U2NXXLUteul2JdMJ+7A pxmw== X-Gm-Message-State: AOAM533P4DpJrWB46ZSwQ027puom9qPlNYFPE/UDVSc1f8HcWFfjLJGL r1Y03NmdEhccgHkc6vwKWTk/5NCs3cMGXpQBz+UC5itYflebShTU4WA0DRfhmo9SFmLgCwpyAT7 0TbzznerefiIjU+SqiUY= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr1436959lfa.499.1649929866656; Thu, 14 Apr 2022 02:51:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfTwEdcYtczFCUnHw5aouWOO125PXoh8qfk/vD3WJJTdYhahNvafR3b6FfxBzBVHMZF5B7r8Sot60dv7uzF24= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr1436946lfa.499.1649929866409; Thu, 14 Apr 2022 02:51:06 -0700 (PDT) MIME-Version: 1.0 References: <1648630829-4372-1-git-send-email-roretzla@linux.microsoft.com> <20220412163013.GA25114@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20220412163013.GA25114@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 14 Apr 2022 11:50:55 +0200 Message-ID: Subject: Re: [PATCH] eal/windows: set Windows main lcore affinitization To: Tyler Retzlaff Cc: dev , Dmitry Kozlyuk Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Tue, Apr 12, 2022 at 6:30 PM Tyler Retzlaff wrote: > > - Which makes me notice that windows/eal_thread.c probably dumps > > random stuff in logs because it is missing a call to > > eal_thread_dump_current_affinity() to format affinity as a string. > > oh yeah, that's not so good. > > i think the series you submitted for eal_thread_loop should resolve this > shouldn't it? shall we ride your change to fix the issue or do you feel > it's worth me adding the missing call in this series? This issue here is only for a log on cpu affinity. Lcores cpu affinity is not correct for Windows in LTS releases, in any case. So let's keep it as is and don't bother fixing it. I'll add a note in my series about this log and apply it. I marked this current patch as "Changes requested", wrt to my first comment. -- David Marchand