From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AAC045B00; Thu, 10 Oct 2024 10:56:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37202402D8; Thu, 10 Oct 2024 10:56:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 36131400D6 for ; Thu, 10 Oct 2024 10:56:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728550599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1D4MHDLijzxSBDQYpt+emUc/AWjRsexy8VQ7YpNDMOs=; b=MYTWC+Y15J821ObisRZkseVN4ltEcHFVlvInoDf/hM5XS7Kw1yd7/4V0mZe7+sZWnZ3v2b PyKZAvMVMgL8ahUwvo2zSs7Ky+hUX17v08wo6ZNFOA1NvJSYeH4NhvONGY9dBx1XahGkdh /r9TyEvBrZmzyOFVQWL2+tPNXTT5qh4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-7cCnEad6MCCCUr3eNhm5rA-1; Thu, 10 Oct 2024 04:56:38 -0400 X-MC-Unique: 7cCnEad6MCCCUr3eNhm5rA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2faca747f94so4427871fa.3 for ; Thu, 10 Oct 2024 01:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728550597; x=1729155397; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1D4MHDLijzxSBDQYpt+emUc/AWjRsexy8VQ7YpNDMOs=; b=wcCrdXIx2HT7WmUJ1ah8d8i568z0EUCepyUr0MHpJ9RwmCMmL8Kuh2xn7mnU/iClgd uBsJTOAi3gbYeSWKtEmyN56Sl8dInXlcgET43tTjfzmpdl2fFjqjrKraqj81Zm/HJheS mVUg66SnJnB+tUcarsTuVCuMVLyMIagWKE4v2Y9YABhUB1T5x5jXAUpgwCjssLbcS8bc hc8X15zjnom2Bql5WFrcPtMQPT5uomtkNxCyuy33plH9szSJcJYGrVF5H7E5pVd5rMsW G44UvYdGHykEDmiqXqWRxm/sFM1/1pfJG8N/bNXKlEMSNW+/5iardy+5ZRwa3vuMxJb/ I7fQ== X-Gm-Message-State: AOJu0Yy7U4AEOH+htJsF5IgvxIjxRDQfQo1V2wCziPs7Q0ZBe4hnYHlI WjkdyttrXa3shO7wkv0ydYgbkI1oouE9uEWiOgbRjFYbNETxs6uAzsGQ+VQbRCx6Z0it6SIxDp2 kuAhahgcHNy+ehRkngenHqLoyCZ/wibsyU6UiiugDC8ASj9JyaJt/CXAp2FzMFjoAzuqEkYG4L0 O+yOM6OJxfR4/c4rI= X-Received: by 2002:a05:651c:2204:b0:2ef:2cdb:5053 with SMTP id 38308e7fff4ca-2fb1f88fd07mr15268091fa.37.1728550596615; Thu, 10 Oct 2024 01:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFOZaJUErRPSHCzYW0OrzmpsIRFnLx3pXXSaZDHi9uGY0SyTSAJ1D/mFDSEQ6v/F/HP2fldQdBlo4uV3T1dOI= X-Received: by 2002:a05:651c:2204:b0:2ef:2cdb:5053 with SMTP id 38308e7fff4ca-2fb1f88fd07mr15267991fa.37.1728550596142; Thu, 10 Oct 2024 01:56:36 -0700 (PDT) MIME-Version: 1.0 References: <20240822103604.113246-1-bruce.richardson@intel.com> <20240822104109.116208-2-bruce.richardson@intel.com> <72489130-4de2-4f59-b454-20a64503320c@amd.com> <5b255af9-b9a3-491a-8d4d-eb6c94b5cee7@amd.com> In-Reply-To: <5b255af9-b9a3-491a-8d4d-eb6c94b5cee7@amd.com> From: David Marchand Date: Thu, 10 Oct 2024 10:56:24 +0200 Message-ID: Subject: Re: [PATCH v2] app/testpmd: show output of commands read from file To: Ferruh Yigit , Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, Ferruh, On Tue, Oct 8, 2024 at 3:33=E2=80=AFAM Ferruh Yigit = wrote: > > On 10/4/2024 5:56 AM, Ferruh Yigit wrote: > > On 8/22/2024 11:41 AM, Bruce Richardson wrote: > >> Testpmd supports the "--cmdline-file" parameter to read a set of initi= al > >> commands from a file. However, the only indication that this has been > >> done successfully on startup is a single-line message, no output from > >> the commands is seen. > >> > >> To improve usability here, we can use cmdline_new rather than > >> cmdline_file_new and have the output from the various commands sent to > >> stdout, allowing the user to see better what is happening. > >> > >> Signed-off-by: Bruce Richardson > >> > >> --- > >> v2: use STDOUT_FILENO in place of hard-coded "1" > >> --- > >> > > > > After discussion, I think it is OK to have the update in the testpmd > > (instead of a new function in cmdline), hence; > > > > Acked-by: Ferruh Yigit > Applied to dpdk-next-net/main, thanks. This patch triggers an error in UNH for Windows builds. Can you have a look? https://lab.dpdk.org/results/dashboard/testruns/logs/1386705/ [756/833] Compiling C object app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj FAILED: app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj "clang" "-Iapp\dpdk-testpmd.exe.p" "-Iapp" "-I..\app" "-Iapp\test-pmd" "-I..\app\test-pmd" "-Ilib\ethdev" "-I..\lib\ethdev" "-I." "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include" "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" "-Ilib\eal" "-I..\lib\eal" "-Ilib\log" "-I..\lib\log" "-Ilib\kvargs" "-I..\lib\kvargs" "-Ilib\net" "-I..\lib\net" "-Ilib\mbuf" "-I..\lib\mbuf" "-Ilib\mempool" "-I..\lib\mempool" "-Ilib\ring" "-I..\lib\ring" "-Ilib\metrics" "-I..\lib\metrics" "-Ilib\telemetry" "-I..\lib\telemetry" "-Ilib\meter" "-I..\lib\meter" "-Ilib\cmdline" "-I..\lib\cmdline" "-Ilib\bitratestats" "-I..\lib\bitratestats" "-Ilib\gro" "-I..\lib\gro" "-Ilib\gso" "-I..\lib\gso" "-Ilib\latencystats" "-I..\lib\latencystats" "-Idrivers\net\i40e" "-I..\drivers\net\i40e" "-Idrivers\net\i40e\base" "-I..\drivers\net\i40e\base" "-Idrivers\bus\pci" "-I..\drivers\bus\pci" "-I..\drivers\bus\pci\windows" "-Ilib\pci" "-I..\lib\pci" "-Idrivers\bus\vdev" "-I..\drivers\bus\vdev" "-Ilib\hash" "-I..\lib\hash" "-Ilib\rcu" "-I..\lib\rcu" "-Idrivers\net\ixgbe" "-I..\drivers\net\ixgbe" "-Idrivers\net\ixgbe\base" "-I..\drivers\net\ixgbe\base" "-Ilib\security" "-I..\lib\security" "-Ilib\cryptodev" "-I..\lib\cryptodev" "-Idrivers\net\iavf" "-I..\drivers\net\iavf" "-Idrivers\common\iavf" "-I..\drivers\common\iavf" "-Idrivers\net\ice" "-I..\drivers\net\ice" "-Idrivers\net\ice\base" "-I..\drivers\net\ice\base" "-Idrivers\net\mlx5" "-I..\drivers\net\mlx5" "-Idrivers\net/mlx5\windows" "-I..\drivers\net\mlx5\windows" "-Idrivers\common\mlx5" "-I..\drivers\common\mlx5" "-Idrivers\common/mlx5\windows" "-I..\drivers\common\mlx5\windows" "-Idrivers\bus\auxiliary" "-I..\drivers\bus\auxiliary" "-IC:\Program Files\Mellanox\MLNX_WinOF2_DevX_SDK\inc" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=3D64" "-Wall" "-Winvalid-pch" "-Wextra" "-Werror" "-std=3Dc11" "-O3" "-include" "rte_config.h" "-Wcast-qual" "-Wdeprecated" "-Wformat" "-Wformat-nonliteral" "-Wformat-security" "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" "-D_GNU_SOURCE" "-D_WIN32_WINNT=3D0x0A00" "-D_CRT_SECURE_NO_WARNINGS" "-march=3Dnative" "-mrtm" "-DALLOW_EXPERIMENTAL_API" "-Wno-deprecated-declarations" -MD -MQ app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj -MF "app\dpdk-testpmd.exe.p\test-pmd_cmdline.c.obj.d" -o app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj "-c" ../app/test-pmd/cmdline.c ../app/test-pmd/cmdline.c:13692:46: error: use of undeclared identifier 'STDOUT_FILENO' cl =3D cmdline_new(main_ctx, "testpmd> ", fd, STDOUT_FILENO); ^ 1 error generated. --=20 David Marchand